Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2396693002: Convert drag event position to root frame. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index e1f4e60dab2f6fe3d66fb59975ba5ed26f25c77d..238b0966ebc6818e8a1a67f1c71ed5c80f122dd2 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -231,22 +231,22 @@ class WEB_EXPORT WebViewImpl final
WebHitTestResult hitTestResultAt(const WebPoint&) override;
WebHitTestResult hitTestResultForTap(const WebPoint&,
const WebSize&) override;
- void dragSourceEndedAt(const WebPoint& clientPoint,
+ void dragSourceEndedAt(const WebPoint& pointInViewport,
const WebPoint& screenPoint,
WebDragOperation) override;
void dragSourceSystemDragEnded() override;
WebDragOperation dragTargetDragEnter(const WebDragData&,
- const WebPoint& clientPoint,
+ const WebPoint& pointInViewport,
const WebPoint& screenPoint,
WebDragOperationsMask operationsAllowed,
int modifiers) override;
- WebDragOperation dragTargetDragOver(const WebPoint& clientPoint,
+ WebDragOperation dragTargetDragOver(const WebPoint& pointInViewport,
const WebPoint& screenPoint,
WebDragOperationsMask operationsAllowed,
int modifiers) override;
void dragTargetDragLeave() override;
void dragTargetDrop(const WebDragData&,
- const WebPoint& clientPoint,
+ const WebPoint& pointInViewport,
const WebPoint& screenPoint,
int modifiers) override;
void spellingMarkers(WebVector<uint32_t>* markers) override;
@@ -572,7 +572,7 @@ class WEB_EXPORT WebViewImpl final
// Consolidate some common code between starting a drag over a target and
// updating a drag over a target. If we're starting a drag, |isEntering|
// should be true.
- WebDragOperation dragTargetDragEnterOrOver(const WebPoint& clientPoint,
+ WebDragOperation dragTargetDragEnterOrOver(const WebPoint& pointInViewport,
const WebPoint& screenPoint,
DragAction,
int modifiers);

Powered by Google App Engine
This is Rietveld 408576698