Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet

Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG=650462
Committed: https://crrev.com/1821cea4d1c74024a434527f780c704e4f297d09
Cr-Commit-Position: refs/heads/master@{#423213}

[Garrett Casto, 2016-10-04 22:39:00]

Description was changed from

==========
Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet

BUG=
==========

to

==========
Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG=
==========

[Garrett Casto, 2016-10-04 22:43:02]

gcasto@chromium.org changed reviewers:
+ dpranke@google.com

[Garrett Casto, 2016-10-04 22:43:03]

This CL is currently incomplete as the PRESUBMIT fails with

** Presubmit ERRORS **
manage (0.17s) failed
cronet_test is listed in gn_isolate_map.pyl but not in any .json files

It's not clear to me if cronet is a special case or if this really should be
added to one of the json files. Advice appreciated.

[Garrett Casto, 2016-10-04 23:00:30]

Description was changed from

==========
Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG=
==========

to

==========
Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG=650462
==========

[sdefresne, 2016-10-05 08:38:59]

On 2016/10/04 22:43:03, Garrett Casto wrote:
> This CL is currently incomplete as the PRESUBMIT fails with
> 
> ** Presubmit ERRORS **
> manage (0.17s) failed
> cronet_test is listed in gn_isolate_map.pyl but not in any .json files
> 
> It's not clear to me if cronet is a special case or if this really should be
> added to one of the json files. Advice appreciated.

The cronet_test is listed in
ios/build/bots/chromium.mac/ios-simulator-cronet.json. Maybe the presubmit check
is incorrect and need to be fixed to also look in that file. I think you can use
"git cl presubmit -v" to find the script that is run as part of the presubmit.
Then from there, investigate why it is reported as not found when in fact it is
referenced.

[Dirk Pranke, 2016-10-05 16:42:14]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-10-05 16:42:14]

The presubmit check isn't smart enough to know about the way iOS lists tests.

Add the binary to:

https://cs.chromium.org/chromium/src/testing/buildbot/manage.py?rcl=0&l=160

to make it shut up :).

lgtm otherwise.

[Garrett Casto, 2016-10-05 16:49:02]

On 2016/10/05 16:42:14, Dirk Pranke (slow) wrote:
> The presubmit check isn't smart enough to know about the way iOS lists tests.
> 
> Add the binary to:
> 
> https://cs.chromium.org/chromium/src/testing/buildbot/manage.py?rcl=0&l=160
> 
> to make it shut up :).
> 
> lgtm otherwise.

Perfect, thanks for your help.

[Garrett Casto, 2016-10-05 16:51:17]

The CQ bit was checked by gcasto@chromium.org

[Garrett Casto, 2016-10-05 16:51:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2396673002/#ps20001
(title: "Fix manage.py")

[commit-bot: I haz the power, 2016-10-05 16:51:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 17:51:05]

Description was changed from

==========
Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG=650462
==========

to

==========
Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG=650462
==========

[commit-bot: I haz the power, 2016-10-05 17:51:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 17:52:34]

Description was changed from

==========
Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG=650462
==========

to

==========
Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG=650462

Committed: https://crrev.com/1821cea4d1c74024a434527f780c704e4f297d09
Cr-Commit-Position: refs/heads/master@{#423213}
==========

[commit-bot: I haz the power, 2016-10-05 17:52:35]

Patchset 2 (id:??) landed as
https://crrev.com/1821cea4d1c74024a434527f780c704e4f297d09
Cr-Commit-Position: refs/heads/master@{#423213}