Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2396603002: Dismiss cros alt+tab UI on escape. (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dismiss cros alt+tab UI on escape. BUG=648351 Committed: https://crrev.com/3b872a197e09c87447a6e1a8fbd5ed6e24ea1577 Cr-Commit-Position: refs/heads/master@{#422989}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/wm/window_cycle_event_filter_aura.cc View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
Evan Stade
4 years, 2 months ago (2016-10-04 20:04:49 UTC) #2
varkha
lgtm + unrelated question. https://codereview.chromium.org/2396603002/diff/1/ash/wm/window_cycle_event_filter_aura.cc File ash/wm/window_cycle_event_filter_aura.cc (right): https://codereview.chromium.org/2396603002/diff/1/ash/wm/window_cycle_event_filter_aura.cc#newcode28 ash/wm/window_cycle_event_filter_aura.cc:28: event->StopPropagation(); Unrelated to this CL. ...
4 years, 2 months ago (2016-10-04 22:00:06 UTC) #3
Evan Stade
https://codereview.chromium.org/2396603002/diff/1/ash/wm/window_cycle_event_filter_aura.cc File ash/wm/window_cycle_event_filter_aura.cc (right): https://codereview.chromium.org/2396603002/diff/1/ash/wm/window_cycle_event_filter_aura.cc#newcode28 ash/wm/window_cycle_event_filter_aura.cc:28: event->StopPropagation(); On 2016/10/04 22:00:06, varkha wrote: > Unrelated to ...
4 years, 2 months ago (2016-10-04 22:42:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396603002/1
4 years, 2 months ago (2016-10-04 22:43:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 23:14:01 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:17:07 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3b872a197e09c87447a6e1a8fbd5ed6e24ea1577
Cr-Commit-Position: refs/heads/master@{#422989}

Powered by Google App Engine
This is Rietveld 408576698