Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 23966003: Update the freetype backed fonthost to keep the style and fixed width attributes for a font stream. (Closed)

Created:
7 years, 3 months ago by djsollen
Modified:
7 years, 3 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update the freetype backed fonthost to keep the style and fixed width attributes for a font stream. This fixes a regression in Android when switching from FontHost_android R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11134

Patch Set 1 #

Patch Set 2 : updating per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M src/fonts/SkFontMgr_fontconfig.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontConfigTypeface.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
djsollen
7 years, 3 months ago (2013-09-06 17:53:11 UTC) #1
reed1
might combine the two constructors for cleanliness. lgtm
7 years, 3 months ago (2013-09-06 17:54:48 UTC) #2
djsollen
7 years, 3 months ago (2013-09-06 18:00:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r11134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698