Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2396583002: Create LayoutNG virtual test suite for fast/block/margin-collapse path. (Closed)

Created:
4 years, 2 months ago by Gleb Lanbin
Modified:
4 years, 2 months ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create LayoutNG virtual test suite for fast/block/margin-collapse path. This creates a LayoutNG virtual test suite for fast/block/margin-collapse path and switches to use "Skip" instead of "Failure" to mark tests that LayoutNG doesn't support at this moment. BUG=635619 Committed: https://crrev.com/f5e4eed6ad759ea4ed120c7d2330d2ae726d6815 Cr-Commit-Position: refs/heads/master@{#422923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +91 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/layout_ng/fast/block/margin-collapse/README.txt View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Gleb Lanbin
4 years, 2 months ago (2016-10-04 19:52:41 UTC) #3
cbiesinger
lgtm
4 years, 2 months ago (2016-10-04 19:53:27 UTC) #5
ikilpatrick
lgtm
4 years, 2 months ago (2016-10-04 19:55:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396583002/1
4 years, 2 months ago (2016-10-04 20:46:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 20:53:51 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 20:55:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5e4eed6ad759ea4ed120c7d2330d2ae726d6815
Cr-Commit-Position: refs/heads/master@{#422923}

Powered by Google App Engine
This is Rietveld 408576698