Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2396533002: Allow multi-line enum entries in java_cpp_enum.py. (Closed)

Created:
4 years, 2 months ago by estevenson
Modified:
4 years, 2 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow multi-line enum entries in java_cpp_enum.py. clang-format wraps long lines, so java_cpp_enum.py should also handle multi-line enum entries. Also changed the HeaderParser to ignore empty comments. BUG=652018 Committed: https://crrev.com/9066edf6a2199aa3390cc55e89a93f858b50761b Cr-Commit-Position: refs/heads/master@{#422863}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make inner functions siblings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -20 lines) Patch
M build/android/gyp/java_cpp_enum.py View 1 3 chunks +43 lines, -20 lines 0 comments Download
M build/android/gyp/java_cpp_enum_tests.py View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
estevenson
ptal Andrew!
4 years, 2 months ago (2016-10-04 15:09:15 UTC) #2
agrieve
lgtm /w one nit. Thanks for adding tests :) https://codereview.chromium.org/2396533002/diff/1/build/android/gyp/java_cpp_enum.py File build/android/gyp/java_cpp_enum.py (right): https://codereview.chromium.org/2396533002/diff/1/build/android/gyp/java_cpp_enum.py#newcode182 build/android/gyp/java_cpp_enum.py:182: ...
4 years, 2 months ago (2016-10-04 15:57:29 UTC) #5
estevenson
https://codereview.chromium.org/2396533002/diff/1/build/android/gyp/java_cpp_enum.py File build/android/gyp/java_cpp_enum.py (right): https://codereview.chromium.org/2396533002/diff/1/build/android/gyp/java_cpp_enum.py#newcode182 build/android/gyp/java_cpp_enum.py:182: def _ParseCurrentEnumEntry(): On 2016/10/04 15:57:28, agrieve wrote: > Looks ...
4 years, 2 months ago (2016-10-04 16:15:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396533002/20001
4 years, 2 months ago (2016-10-04 16:16:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 18:27:53 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:30:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9066edf6a2199aa3390cc55e89a93f858b50761b
Cr-Commit-Position: refs/heads/master@{#422863}

Powered by Google App Engine
This is Rietveld 408576698