Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java

Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface. (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
index 6e3bdf47afaa10837ffe74d1f58d5c110f37f668..4d68c653b2a99dc06a88f1a4fcdf9e6605f97b67 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java
@@ -4,13 +4,14 @@
package org.chromium.chrome.browser.ntp.snippets;
-import org.chromium.chrome.browser.ntp.cards.NewTabPageItem;
+import org.chromium.chrome.browser.ntp.cards.ItemViewType;
+import org.chromium.chrome.browser.ntp.cards.Leaf;
import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder;
/**
* Represents the data for a header of a group of snippets
*/
-public class SectionHeader implements NewTabPageItem {
+public class SectionHeader extends Leaf {
/** Whether the header should be shown. */
private final boolean mVisible;
@@ -26,8 +27,9 @@ public class SectionHeader implements NewTabPageItem {
}
@Override
- public int getType() {
- return NewTabPageItem.VIEW_TYPE_HEADER;
+ @ItemViewType
+ public int getItemViewType() {
+ return ItemViewType.HEADER;
}
public boolean isVisible() {
@@ -39,7 +41,7 @@ public class SectionHeader implements NewTabPageItem {
}
@Override
- public void onBindViewHolder(NewTabPageViewHolder holder) {
+ protected void onBindViewHolder(NewTabPageViewHolder holder) {
assert holder instanceof SectionHeaderViewHolder;
((SectionHeaderViewHolder) holder).onBindViewHolder(this);
}

Powered by Google App Engine
This is Rietveld 408576698