Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java

Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface. (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
index 428c97fed34e7b3c119644dd7ca9bf9d0b34775a..788aa7f6f55b0bd031b8a82ef5e9c0766a16542f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
@@ -10,12 +10,13 @@ package org.chromium.chrome.browser.ntp.cards;
*
* @see ProgressViewHolder
*/
-class ProgressItem implements NewTabPageItem {
+class ProgressItem extends Leaf {
private boolean mVisible = false;
@Override
- public int getType() {
- return NewTabPageItem.VIEW_TYPE_PROGRESS;
+ @ItemViewType
+ protected int getItemViewType() {
+ return ItemViewType.PROGRESS;
}
public boolean isVisible() {
@@ -27,7 +28,7 @@ class ProgressItem implements NewTabPageItem {
}
@Override
- public void onBindViewHolder(NewTabPageViewHolder holder) {
+ protected void onBindViewHolder(NewTabPageViewHolder holder) {
assert holder instanceof ProgressViewHolder;
((ProgressViewHolder) holder).onBindViewHolder(this);
}

Powered by Google App Engine
This is Rietveld 408576698