chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java - Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java

Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface. (Closed)

Patch Set: review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java

index 7698c5a4db6411904fbd33a066d549331000f086..9b8589dbc855b179b3887900745b55d77c163a59 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java

@@ -18,14 +18,15 @@ import org.chromium.ui.text.SpanApplier;

/**

* A footer to show some text and a link to learn more.

-public class Footer extends SingleItemGroup {

+public class Footer extends Leaf {

@Override

- public int getType() {

- return NewTabPageItem.VIEW_TYPE_FOOTER;

+ @ItemViewType

+ protected int getItemViewType() {

+ return ItemViewType.FOOTER;

}

@Override

- public void onBindViewHolder(NewTabPageViewHolder holder) {

+ protected void onBindViewHolder(NewTabPageViewHolder holder) {

// Nothing to do (the footer view is static).

}