Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface. (Closed)
Patch Set: review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
index f5d553ee12475391acf8b99871ac5c96f0ff3bd2..9cf31a288d6d2c4b9eaaec7f0677bde2657d2122 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
@@ -233,19 +233,19 @@ public class CardViewHolder extends NewTabPageViewHolder {
return LayoutInflater.from(parent.getContext()).inflate(resourceId, parent, false);
}
- public static boolean isCard(@NewTabPageItem.ViewType int type) {
+ public static boolean isCard(@ItemViewType int type) {
switch (type) {
- case NewTabPageItem.VIEW_TYPE_SNIPPET:
- case NewTabPageItem.VIEW_TYPE_STATUS:
- case NewTabPageItem.VIEW_TYPE_ACTION:
- case NewTabPageItem.VIEW_TYPE_PROMO:
+ case ItemViewType.SNIPPET:
+ case ItemViewType.STATUS:
+ case ItemViewType.ACTION:
+ case ItemViewType.PROMO:
return true;
- case NewTabPageItem.VIEW_TYPE_ABOVE_THE_FOLD:
- case NewTabPageItem.VIEW_TYPE_HEADER:
- case NewTabPageItem.VIEW_TYPE_SPACING:
- case NewTabPageItem.VIEW_TYPE_PROGRESS:
- case NewTabPageItem.VIEW_TYPE_FOOTER:
- case NewTabPageItem.VIEW_TYPE_ALL_DISMISSED:
+ case ItemViewType.ABOVE_THE_FOLD:
+ case ItemViewType.HEADER:
+ case ItemViewType.SPACING:
+ case ItemViewType.PROGRESS:
+ case ItemViewType.FOOTER:
+ case ItemViewType.ALL_DISMISSED:
return false;
default:
assert false;

Powered by Google App Engine
This is Rietveld 408576698