chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java - Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Issue 2396523002: Unify NewTabPageItem and ItemGroup into a single tree-structured interface. (Closed)

Patch Set: review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

index b0c46c378111f840052f583fa1543a9d1a58623e..9f66edd383bbfbfef08cc92c39d891f7e7e8e0bd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

@@ -174,7 +174,7 @@ public class NewTabPageRecyclerView extends RecyclerView {

// It might not be in the layout yet if it's not visible or ready to be displayed.

if (bottomSpacingViewHolder == null) return;

- assert bottomSpacingViewHolder.getItemViewType() == NewTabPageItem.VIEW_TYPE_SPACING;

+ assert bottomSpacingViewHolder.getItemViewType() == ItemViewType.SPACING;

bottomSpacingViewHolder.itemView.requestLayout();

}