Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2396503002: Fix net_export.h includes. (Closed)

Created:
4 years, 2 months ago by Bence
Modified:
4 years, 2 months ago
Reviewers:
asanka, eroman
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, Paweł Hajdan Jr., eroman, kinuko+cache_chromium.org, mmenke, Eran Messeri
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix net_export.h includes. Include net_export.h in header files if and only if it is used in that header file. Include net_export.h in .cc files if and only if it is used in that file and it is not included in the header file. This CL only adds and removes the line '#include "net/base/net_export.h"'. Committed: https://crrev.com/81c46c1f1ba6f6e851e4dc835bf78672d352e6a4 Cr-Commit-Position: refs/heads/master@{#422824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -14 lines) Patch
M net/android/http_auth_negotiate_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/android/network_change_notifier_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/android/network_change_notifier_delegate_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/address_tracker_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/layered_network_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/net_error_details.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/network_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/network_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/network_interfaces_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/priority_queue.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/winsock_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cert/ct_sct_to_string.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/internal/cert_issuer_source_aia.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/internal/cert_issuer_source_static.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/internal/extended_key_usage.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/internal/name_constraints.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/internal/parse_ocsp.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/blockfile/disk_format_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/entry_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/blockfile/rankings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/memory/mem_entry_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/mdns_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/mdns_client_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/filter/source_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_network_transaction.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/bidirectional_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/disk_cache_based_quic_server_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/failing_http_transaction_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_auth_handler_ntlm.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_auth_scheme.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_auth_scheme.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_transaction.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/proxy_client_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/log/bounded_file_net_log_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/log/write_to_file_net_log_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/network_delegate_error_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/polling_proxy_config_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_config_service_fixed.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_config_service_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/crypto/channel_id_chromium.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_alarm_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_connection_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_packet_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_connection_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_http_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/loss_detection_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/pacing_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/prr_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_decrypter.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_encrypter.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_decrypter.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_encrypter.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/crypto_protocol.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_bandwidth.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_client_promised_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_client_push_promise_index.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_client_session_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_crypto_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_frame_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_multipath_received_packet_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_multipath_transmissions_map.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_packet_creator.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_packet_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_received_packet_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_sent_entropy_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_server_session_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_simple_buffer_allocator.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_sustained_bandwidth_recorder.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/sdch/sdch_owner.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/next_proto.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/socket_posix.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/socks5_client_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/socks_client_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/socks_client_socket_pool.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_client_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/stream_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/hpack/hpack_static_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/hpack/hpack_static_table_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/http2_priority_dependencies.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_http_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_session_key.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/write_scheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/test/url_request/url_request_hanging_read_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/url_request/url_request_mock_data_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_default_packet_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/synchronous_host_resolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/udp/datagram_client_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/udp/datagram_server_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/udp/udp_client_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/udp/udp_server_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/data_protocol_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/file_protocol_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/ftp_protocol_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/report_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/sdch_dictionary_fetcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_data_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_test_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_throttler_entry.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_basic_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_errors.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_handshake_stream_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_stream_create_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Bence
Asanka: PTAL. Thank you.
4 years, 2 months ago (2016-10-04 15:50:00 UTC) #6
eroman
lgtm
4 years, 2 months ago (2016-10-04 16:09:01 UTC) #8
Bence
On 2016/10/04 16:09:01, eroman wrote: > lgtm Thank you.
4 years, 2 months ago (2016-10-04 16:17:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396503002/1
4 years, 2 months ago (2016-10-04 16:17:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 16:26:24 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:28:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81c46c1f1ba6f6e851e4dc835bf78672d352e6a4
Cr-Commit-Position: refs/heads/master@{#422824}

Powered by Google App Engine
This is Rietveld 408576698