chrome/browser/resources/ssl/blocking.html - Issue 23965003: New SSL blocking screen

Side by Side Diff: chrome/browser/resources/ssl/blocking.html

Issue 23965003: New SSL blocking screen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactored to share more code Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html i18n-values="dir:textDirection">

	3 <head>

	4 <meta name="viewport" content="width=device-width, initial-scale=1.0,

	5 maximum-scale=1.0, user-scalable=no">

	6 <title i18n-content="title"></title>

	7 <link rel="stylesheet" href="../../../renderer/resources/neterror.css">

	8 <link rel="stylesheet" href="blocking.css">

	9 <script src="../../../../ui/webui/resources/js/util.js"></script>

	10 <script src="../../../renderer/resources/neterror.js"></script>

	11 <script src="shared.js"></script>
	Patrick Dubroy 2013/09/18 15:01:35 Can you give this a slightly more descriptive name Can you give this a slightly more descriptive name? felt 2013/10/18 05:53:12 Done. Show quoted text On 2013/09/18 15:01:35, Patrick Dubroy wrote: > Can you give this a slightly more descriptive name? Done.
	12 <script src="blocking.js"></script>

	13 </head>

	14 <body id="t">

	15 <div id="main-frame-error">

	16 <div id="box">

	17 <div id="content-top">

	18 <h1>

	19 <div>

	20 <img class="icon" id="icon-lock">

	21 </div>

	22 <span i18n-content="headline"></span>

	23 </h1>

	24 <div class="explanation-par">
	Patrick Dubroy 2013/09/18 15:01:35 Looks like this should be a <p>. Looks like this should be a <p>. felt 2013/10/18 05:53:12 Done. Show quoted text On 2013/09/18 15:01:35, Patrick Dubroy wrote: > Looks like this should be a <p>. Done.
	25 <span i18n-values=".innerHTML:message"></span>

	26 </div>

	27 <button id="reload-button" i18n-content="reloadMsg"></button>

	28 <button id="more-less-button" i18n-content="more"></button>

	29 </div>

	30 <div id="help-box-outer" class="hidden">

	31 <div id="help-box-inner">

	32 <div class="ssl-help-box-inner">

	33 <h2><span i18n-content="moreTitle"></span></h2>
	Patrick Dubroy 2013/09/18 15:01:35 I think you can get rid of the <span> here, and ju I think you can get rid of the <span> here, and just put i18n-content on the h2. felt 2013/10/18 05:53:12 Done. Show quoted text On 2013/09/18 15:01:35, Patrick Dubroy wrote: > I think you can get rid of the <span> here, and just put i18n-content on the h2. Done.
	34 <span i18n-values=".innerHTML:moreMessage"></p>
	Patrick Dubroy 2013/09/18 15:01:35 Mismatched opening and closing tags. I think you c Mismatched opening and closing tags. I think you can just use <p>. felt 2013/10/18 05:53:12 Done. Show quoted text On 2013/09/18 15:01:35, Patrick Dubroy wrote: > Mismatched opening and closing tags. I think you can just use <p>. Done.
	35 </div>

	36 <div class="ssl-help-box-inner">

	37 <h2><span i18n-content="techTitle"></span></h2>

	38 <p i18n-content="failure"></p>

	39 <span i18n-content="errorType"></span><br>
	Patrick Dubroy 2013/09/18 15:01:35 Why are these <span>, and not <p>? Why are these <span>, and not <p>? felt 2013/10/18 05:53:12 The <p> adds too much whitespace between them. I w Show quoted text On 2013/09/18 15:01:35, Patrick Dubroy wrote: > Why are these <span>, and not <p>? The <p> adds too much whitespace between them. I want them to be on newlines, but without the extra spacing. They are meant to be viewed as a single text block with some formatting. Patrick Dubroy 2013/10/21 07:48:50 I see. Show quoted text On 2013/10/18 05:53:12, felt wrote: > On 2013/09/18 15:01:35, Patrick Dubroy wrote: > > Why are these <span>, and not <p>? > > The <p> adds too much whitespace between them. I want them to be on newlines, > but without the extra spacing. They are meant to be viewed as a single text > block with some formatting. I see.
	40 <span i18n-content="subject"></span><br>

	41 <span i18n-content="issuer"></span><br>

	42 <span i18n-content="fingerprint"></span>

	43 </div>

	44 </div>

	45 </div>

	46 </div>

	47 </div>

	48 </body>

	49 </html>

OLD	NEW