Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2235)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2396493002: Improve the TestNavigationManager (Closed)
Patch Set: Addressed Nasko's nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index 48b7d03b985ae0489867021810d415e613ead2b2..53b20555e35cc83347e649076ff74458745dbb9c 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -336,7 +336,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortNewNavigation) {
browser()->tab_strip_model()->GetActiveWebContents(), url);
chrome::Navigate(&params);
- EXPECT_TRUE(manager.WaitForWillStartRequest());
+ EXPECT_TRUE(manager.WaitForRequestStart());
GURL url2(embedded_test_server()->GetURL("/title2.html"));
chrome::NavigateParams params2(browser(), url2,
@@ -359,7 +359,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortReload) {
browser()->tab_strip_model()->GetActiveWebContents(), url);
chrome::Navigate(&params);
- EXPECT_TRUE(manager.WaitForWillStartRequest());
+ EXPECT_TRUE(manager.WaitForRequestStart());
chrome::NavigateParams params2(browser(), url, ui::PAGE_TRANSITION_RELOAD);
content::TestNavigationManager manager2(
@@ -380,7 +380,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortClose) {
browser()->tab_strip_model()->GetActiveWebContents(), url);
chrome::Navigate(&params);
- EXPECT_TRUE(manager.WaitForWillStartRequest());
+ EXPECT_TRUE(manager.WaitForRequestStart());
browser()->tab_strip_model()->GetActiveWebContents()->Close();
@@ -399,7 +399,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortMultiple) {
browser()->tab_strip_model()->GetActiveWebContents(), url);
chrome::Navigate(&params);
- EXPECT_TRUE(manager.WaitForWillStartRequest());
+ EXPECT_TRUE(manager.WaitForRequestStart());
GURL url2(embedded_test_server()->GetURL("/title2.html"));
chrome::NavigateParams params2(browser(), url2, ui::PAGE_TRANSITION_TYPED);
@@ -407,7 +407,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortMultiple) {
browser()->tab_strip_model()->GetActiveWebContents(), url2);
chrome::Navigate(&params2);
- EXPECT_TRUE(manager2.WaitForWillStartRequest());
+ EXPECT_TRUE(manager2.WaitForRequestStart());
manager.WaitForNavigationFinished();
GURL url3(embedded_test_server()->GetURL("/title3.html"));
@@ -416,7 +416,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortMultiple) {
browser()->tab_strip_model()->GetActiveWebContents(), url3);
chrome::Navigate(&params3);
- EXPECT_TRUE(manager3.WaitForWillStartRequest());
+ EXPECT_TRUE(manager3.WaitForRequestStart());
manager2.WaitForNavigationFinished();
manager3.WaitForNavigationFinished();
@@ -437,7 +437,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortClientRedirect) {
content::TestNavigationManager manager(
browser()->tab_strip_model()->GetActiveWebContents(), second_url);
chrome::Navigate(&params);
- EXPECT_TRUE(manager.WaitForWillStartRequest());
+ EXPECT_TRUE(manager.WaitForRequestStart());
{
content::TestNavigationManager reload_manager(
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698