components/user_prefs/tracked/hash_store_contents.h - Issue 2396443002: Revert of Integrate registry_hash_store_contents with the rest of tracked prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_prefs/tracked/hash_store_contents.h

Issue 2396443002: Revert of Integrate registry_hash_store_contents with the rest of tracked prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/user_prefs/tracked/dictionary_hash_store_contents.cc ('k') | components/user_prefs/tracked/pref_hash_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/user_prefs/tracked/hash_store_contents.h

diff --git a/components/user_prefs/tracked/hash_store_contents.h b/components/user_prefs/tracked/hash_store_contents.h

index 9cc8abba09093e979833ef030a19b20e3195d05d..91441c8fb91d5f904ece2420e6d8818e38fa9f17 100644

--- a/components/user_prefs/tracked/hash_store_contents.h

+++ b/components/user_prefs/tracked/hash_store_contents.h

@@ -25,15 +25,6 @@

class HashStoreContents {

public:

virtual ~HashStoreContents() {}

- // Returns true if this implementation of HashStoreContents can be copied via

- // MakeCopy().

- virtual bool IsCopyable() const = 0;

- // Returns a copy of this HashStoreContents. Must only be called on

- // lightweight implementations (which return true from IsCopyable()) and only

- // in scenarios where a copy cannot be avoided.

- virtual std::unique_ptr<HashStoreContents> MakeCopy() const = 0;

// Returns the suffix to be appended to UMA histograms for this store type.

// The returned value must either be an empty string or one of the values in