src/compiler/wasm-compiler.cc - Issue 2396433008: [wasm] Add guard regions to end of WebAssembly.Memory buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2396433008: [wasm] Add guard regions to end of WebAssembly.Memory buffers (Closed)

Patch Set: Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into guard-pages Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/wasm-compiler.cc

diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc

index a0a1b7a23acecef961d1b267284db6f030cd2845..f5a90f40a7eee70df98669be7ab3483505fb6096 100644

--- a/src/compiler/wasm-compiler.cc

+++ b/src/compiler/wasm-compiler.cc

@@ -2970,6 +2970,7 @@ Node* WasmGraphBuilder::LoadMem(wasm::LocalType type, MachineType memtype,

if (aligned ||

jsgraph()->machine()->UnalignedLoadSupported(memtype, alignment)) {

if (FLAG_wasm_trap_handler) {

+ DCHECK(FLAG_wasm_guard_pages);

titzer 2016/11/09 19:23:47 Generally want to avoid DCHECK'ing flags IMO.

Node* context = HeapConstant(module_->instance->context);

Node* position_node = jsgraph()->Int32Constant(position);

load = graph()->NewNode(jsgraph()->machine()->ProtectedLoad(memtype),