src/flag-definitions.h - Issue 2396433008: [wasm] Add guard regions to end of WebAssembly.Memory buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 2396433008: [wasm] Add guard regions to end of WebAssembly.Memory buffers (Closed)

Patch Set: Code review feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index cabd7bdbdf5411586e027fc19868f40de2547810..6f119a3fb5d0d87865f265c452872f6b848de7b8 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -532,7 +532,9 @@ DEFINE_BOOL(wasm_atomics_prototype, false,

DEFINE_BOOL(wasm_trap_handler, false,

"use signal handlers to catch out of bounds memory access in wasm"

- " (currently Linux x86_64 only)")

+ " (experimental, currently Linux x86_64 only)")

+DEFINE_BOOL(wasm_guard_pages, false,

+ "add guard pages to the end of WebWassembly memory (experimental)")

// Profiler flags.

DEFINE_INT(frame_count, 1, "number of stack frames inspected by the profiler")