Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2396433007: Travis / chrome fixes (Closed)

Created:
4 years, 2 months ago by vsm
Modified:
4 years, 2 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Travis / chrome fixes - Use google-chrome-stable by default - Use google-chrome-unstable as Canary (instead of trying to determine last-known-good-revision - we has issues with that yesterday) - Test chrome stable and unstable separately on travis Try bot: https://travis-ci.org/dart-lang/sdk/builds/165541943 R=kevmoo@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8846988b1dd81256938097c9d36bab644f39066d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M .travis.yml View 3 chunks +10 lines, -2 lines 0 comments Download
M pkg/dev_compiler/karma.conf.js View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/get_chrome_canary.sh View 1 chunk +1 line, -3 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
vsm
https://codereview.chromium.org/2396433007/diff/1/pkg/dev_compiler/tool/get_chrome_canary.sh File pkg/dev_compiler/tool/get_chrome_canary.sh (right): https://codereview.chromium.org/2396433007/diff/1/pkg/dev_compiler/tool/get_chrome_canary.sh#newcode38 pkg/dev_compiler/tool/get_chrome_canary.sh:38: readonly CHROME_REV=$(curl -s ${CHROME_URL}/LAST_CHANGE) Note - we don't use ...
4 years, 2 months ago (2016-10-06 15:07:30 UTC) #3
kevmoo
lgtm
4 years, 2 months ago (2016-10-06 15:26:24 UTC) #4
vsm
Committed patchset #1 (id:1) manually as 8846988b1dd81256938097c9d36bab644f39066d (presubmit successful).
4 years, 2 months ago (2016-10-06 15:33:14 UTC) #6
Bob Nystrom
4 years, 2 months ago (2016-10-06 16:07:13 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698