third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py - Issue 2396433004: Reland of "update SCM and expectations all at once after all commands".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

Issue 2396433004: Reland of "update SCM and expectations all at once after all commands". (Closed)

Patch Set: Add file to list of files to rm from SCM even if it doesn't exist in SCM. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

index 5b77580ff787dd91280a96e15f274a4de09e0a23..6bc071542be0719de9df0be9266d00a7f535c134 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

@@ -251,6 +251,7 @@ class BaselineOptimizer(object):

_log.debug(" " + platform_dir)

for filename in fs_files:

self._filesystem.remove(filename)

+ self._files_to_delete.extend(scm_files)

qyearsley 2016/10/04 22:41:37 This is a fix that I think in theory should preven

else:

_log.debug(" (Nothing to delete)")

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py » ('j') | no next file with comments »