Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2396423002: MemoryResourceProvider.getFolder() should not create the folder. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

MemoryResourceProvider.getFolder() should not create the folder. But newFolder() should be used to create. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d4ebdabf430d8d44de5b971db134d47689647831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M pkg/analysis_server/test/single_context_manager_test.dart View 8 chunks +14 lines, -1 line 0 comments Download
M pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analyzer/test/source/package_map_provider_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-07 16:57:51 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-07 17:07:43 UTC) #2
scheglov
4 years, 2 months ago (2016-10-07 17:12:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d4ebdabf430d8d44de5b971db134d47689647831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698