|
|
Chromium Code Reviews
DescriptionRoll WebGL 79ef088..a5f3d8b
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/79ef088..a5f3d8b
BUG=654201
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/d186b676595d4cda27feb6f1f9e37ac48636f679
Cr-Commit-Position: refs/heads/master@{#424325}
Patch Set 1 #Patch Set 2 : suppress webgl2 expectation #Patch Set 3 : Attach the issue to specific crbug #
Total comments: 1
Messages
Total messages: 35 (29 generated)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll WebGL 79ef088..a5f3d8b https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/79ef08... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 79ef088..a5f3d8b https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/79ef08... BUG=654201 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I run the latest Chromium with latest WebGL 2 CTS after holiday, found that getBufferSubData.html fails. Roll in the latest WebGL CTS to expose the issue. PTAL. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks Yunchao for helping with this roll. CC'ing kainino@ because he expanded the cases in this test which caused it to start failing. LGTM, but I'm surprised the new test doesn't have to be marked failing on macOS. https://codereview.chromium.org/2396403004/diff/40001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2396403004/diff/40001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:57: ['win'], bug=654201) I thought this new test was failing on all platforms.
On 2016/10/10 20:53:26, Ken Russell wrote: > Thanks Yunchao for helping with this roll. > > CC'ing kainino@ because he expanded the cases in this test which caused it to > start failing. > > LGTM, but I'm surprised the new test doesn't have to be marked failing on macOS. I vaguely remember on MacOSX vrams are initialized at allocation time. > > https://codereview.chromium.org/2396403004/diff/40001/content/test/gpu/gpu_te... > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > https://codereview.chromium.org/2396403004/diff/40001/content/test/gpu/gpu_te... > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:57: ['win'], > bug=654201) > I thought this new test was failing on all platforms.
The CQ bit was checked by yunchao.he@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 79ef088..a5f3d8b https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/79ef08... BUG=654201 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 79ef088..a5f3d8b https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/79ef08... BUG=654201 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 79ef088..a5f3d8b https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/79ef08... BUG=654201 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 79ef088..a5f3d8b https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/79ef08... BUG=654201 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/d186b676595d4cda27feb6f1f9e37ac48636f679 Cr-Commit-Position: refs/heads/master@{#424325} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d186b676595d4cda27feb6f1f9e37ac48636f679 Cr-Commit-Position: refs/heads/master@{#424325} |
