Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3021)

Unified Diff: runtime/vm/object.h

Issue 23964003: Traverse inlined frames lazily when printing the stacktrace. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 27208)
+++ runtime/vm/object.h (working copy)
@@ -5856,26 +5856,22 @@
intptr_t Length() const;
RawFunction* FunctionAtFrame(intptr_t frame_index) const;
- void SetFunctionAtFrame(intptr_t frame_index, const Function& func) const;
RawCode* CodeAtFrame(intptr_t frame_index) const;
void SetCodeAtFrame(intptr_t frame_index, const Code& code) const;
RawSmi* PcOffsetAtFrame(intptr_t frame_index) const;
void SetPcOffsetAtFrame(intptr_t frame_index, const Smi& pc_offset) const;
- void SetCatchStacktrace(const Array& func_array,
- const Array& code_array,
+ void SetCatchStacktrace(const Array& code_array,
const Array& pc_offset_array) const;
+ void set_expand_inlined(bool value) const;
- void Append(const Array& func_list,
- const Array& code_list,
- const Array& pc_offset_list) const;
+ void Append(const Array& code_list, const Array& pc_offset_list) const;
static intptr_t InstanceSize() {
return RoundedAllocationSize(sizeof(RawStacktrace));
}
- static RawStacktrace* New(const Array& func_array,
- const Array& code_array,
+ static RawStacktrace* New(const Array& code_array,
const Array& pc_offset_array,
Heap::Space space = Heap::kNew);
@@ -5883,12 +5879,11 @@
const char* ToCStringInternal(intptr_t frame_index) const;
private:
- void set_function_array(const Array& function_array) const;
void set_code_array(const Array& code_array) const;
void set_pc_offset_array(const Array& pc_offset_array) const;
- void set_catch_func_array(const Array& function_array) const;
void set_catch_code_array(const Array& code_array) const;
void set_catch_pc_offset_array(const Array& pc_offset_array) const;
+ bool expand_inlined() const;
FINAL_HEAP_OBJECT_IMPLEMENTATION(Stacktrace, Instance);
friend class Class;
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698