Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation

Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation (patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
>
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
>
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
>
> BUG=603396
>
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
Cr-Commit-Position: refs/heads/master@{#423868}

[Finnur, 2016-10-07 15:51:09]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-10-07 15:51:10]

Created Revert of Clear mojo URLLoaderClient in ResourceDispatcher on
cancellation

[commit-bot: I haz the power, 2016-10-07 15:51:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-10-07 15:52:15]

Description was changed from

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> 
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
> 
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
> 
> BUG=603396
> 
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
==========

to

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> 
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
> 
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
> 
> BUG=603396
> 
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
==========

[Finnur, 2016-10-07 15:52:15]

finnur@chromium.org changed reviewers:
+ gab@chromium.org, kinuko@chromium.org, nasko@chromium.org

[commit-bot: I haz the power, 2016-10-07 15:52:19]

Description was changed from

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> 
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
> 
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
> 
> BUG=603396
> 
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
==========

to

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> 
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
> 
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
> 
> BUG=603396
> 
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
==========

[commit-bot: I haz the power, 2016-10-07 15:52:20]

Committed patchset #1 (id:1)

[Finnur, 2016-10-07 15:53:55]

Fellow sheriffs: Weekend is almost upon us here in Europe and the shift about to
end, so I'm not sure I'll be able to check on the results of this. Please
monitor (those starting their shift).

[commit-bot: I haz the power, 2016-10-07 15:53:55]

Description was changed from

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> 
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
> 
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
> 
> BUG=603396
> 
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
==========

to

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
>
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
>
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
>
> BUG=603396
>
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396

Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
Cr-Commit-Position: refs/heads/master@{#423868}
==========

[commit-bot: I haz the power, 2016-10-07 15:53:56]

Patchset 1 (id:??) landed as
https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
Cr-Commit-Position: refs/heads/master@{#423868}

[Finnur, 2016-10-07 15:55:29]

Description was changed from

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
>
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
>
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
>
> BUG=603396
>
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396

Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
Cr-Commit-Position: refs/heads/master@{#423868}
==========

to

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
>
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
>
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
>
> BUG=603396
>
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396

Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
Cr-Commit-Position: refs/heads/master@{#423868}
==========

[Finnur, 2016-10-07 15:55:29]

finnur@chromium.org changed reviewers:
+ lukasza@chromium.org

[Finnur, 2016-10-07 15:56:26]

Adding Łukasz, who is looking into his test failure (and monitoring this on the
side).

[gab, 2016-10-07 16:00:28]

Description was changed from

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
>
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
>
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
>
> BUG=603396
>
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396

Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
Cr-Commit-Position: refs/heads/master@{#423868}
==========

to

==========
Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )

Reason for revert:
This is a speculative revert...

Two tests started failing somewhat reliably on Win7 in the build where this was
checked in and all the other CLs in that build look completely unrelated.

NavigatingExtensionPopupBrowserTest.DownloadViaPost
PageLoadMetricsBrowserTest.IgnoreDownloads

https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests

I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.

Original issue's description:
> Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
>
> If a URL request is cancelled by a requester, there's a chance on
> URLResponseBodyConsumer to run OnReadable() on an invalid
> ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> access.
>
> This CL clears the URLLoaderClient earlier in the cancellation phase to
> avoid the crash.
>
> BUG=603396
>
> Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> Cr-Commit-Position: refs/heads/master@{#423779}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396

Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
Cr-Commit-Position: refs/heads/master@{#423868}
==========

[Finnur, 2016-10-07 16:01:58]

And... as I check this in I notice the bot has surprisingly turned green all of
a sudden (build 11011):
https://build.chromium.org/p/chromium.win/builders/Win7%20(32)%20Tests

If it stays green for a couple of runs we can probably revert this CL and this
one:
https://codereview.chromium.org/2401003002

[gab, 2016-10-07 16:42:32]

On 2016/10/07 16:01:58, Finnur wrote:
> And... as I check this in I notice the bot has surprisingly turned green all
of
> a sudden (build 11011):
> https://build.chromium.org/p/chromium.win/builders/Win7%20(32)%20Tests
> 
> If it stays green for a couple of runs we can probably revert this CL and this
> one:
> https://codereview.chromium.org/2401003002

Still flaking twice after that, last one @ r423864 (just before this revert),
we'll see in next one very soon.

[gab, 2016-10-07 16:55:59]

On 2016/10/07 16:42:32, gab wrote:
> On 2016/10/07 16:01:58, Finnur wrote:
> > And... as I check this in I notice the bot has surprisingly turned green all
> of
> > a sudden (build 11011):
> > https://build.chromium.org/p/chromium.win/builders/Win7%20(32)%20Tests
> > 
> > If it stays green for a couple of runs we can probably revert this CL and
this
> > one:
> > https://codereview.chromium.org/2401003002
> 
> Still flaking twice after that, last one @ r423864 (just before this revert),
> we'll see in next one very soon.

Still flaked @ r423870 :
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20%2832%29%...

Will reland this CL.

[gab, 2016-10-07 16:56:20]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2400263002/ by gab@chromium.org.

The reason for reverting is: Still flakes after this revert, relanding..