Issue 2396383002: Fixed the Wrong Parameter Passed to VulkanBrowserCompositorOutputSurface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2396383002: Fixed the Wrong Parameter Passed to VulkanBrowserCompositorOutputSurface.

Created:
4 years, 2 months ago by Soorya

Modified:
4 years, 2 months ago

Reviewers:
a.suchit2, a.suchit

CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixed the Wrong Parameter Passed to VulkanBrowserCompositorOutputSurface. The third parameter of VulkanBrowserCompositorOutputSurface constructor expects cc::SyntheticBeginFrameSource* . But it is wrongly passed as compositor->task_runner().get(). Changed the third parameter to begin_frame_source.get(). BUG = 582558 , 582564

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/compositor/gpu_process_transport_factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

a.suchit2

4 years, 2 months ago (2016-10-10 10:53:27 UTC) #4

Please upload a single patch for all the build issues in vulkan.

peer review not looks good to me.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages