src/keys.cc - Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/keys.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/keys.cc

diff --git a/src/keys.cc b/src/keys.cc

index d0fe72f8967d43fc513a990f9a64018e4c96b1b3..c6e31e3f231ccc855356d33c9c61b518fd3061e5 100644

--- a/src/keys.cc

+++ b/src/keys.cc

@@ -780,7 +780,7 @@ Maybe<bool> KeyAccumulator::CollectOwnJSProxyKeys(Handle<JSReceiver> receiver,

target_keys->get(i));

nonconfigurable_keys_length++;

// The key was moved, null it out in the original list.

- target_keys->set(i, Smi::kZero);

+ target_keys->set(i, Smi::FromInt(0));

} else {

// 14c. Else,

// 14c i. Append key as an element of targetConfigurableKeys.

« no previous file with comments | « src/isolate.cc ('k') | src/layout-descriptor-inl.h » ('j') | no next file with comments »