Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

src/runtime/runtime-debug.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include "src/arguments.h"
 #include "src/debug/debug-evaluate.h"
 #include "src/debug/debug-frames.h"
 #include "src/debug/debug-scopes.h"
@@ skipping 29 matching lines @@
   SealHandleScope shs(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(Object, value, 0);
   isolate->debug()->set_return_value(value);
 
   // Get the top-most JavaScript frame.
   JavaScriptFrameIterator it(isolate);
   isolate->debug()->Break(it.frame());
 
   // If live-edit has dropped frames, we are not going back to dispatch.
-  if (LiveEdit::SetAfterBreakTarget(isolate->debug())) return Smi::kZero;
+  if (LiveEdit::SetAfterBreakTarget(isolate->debug())) return Smi::FromInt(0);
 
   // Return the handler from the original bytecode array.
   DCHECK(it.frame()->is_interpreted());
   InterpretedFrame* interpreted_frame =
       reinterpret_cast<InterpretedFrame*>(it.frame());
   SharedFunctionInfo* shared = interpreted_frame->function()->shared();
   BytecodeArray* bytecode_array = shared->bytecode_array();
   int bytecode_offset = interpreted_frame->GetBytecodeOffset();
   interpreter::Bytecode bytecode =
       interpreter::Bytecodes::FromByte(bytecode_array->get(bytecode_offset));
@@ skipping 389 matching lines @@
   HandleScope scope(isolate);
   DCHECK(args.length() == 1);
   CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]);
   CHECK(isolate->debug()->CheckExecutionState(break_id));
 
   // Count all frames which are relevant to debugging stack trace.
   int n = 0;
   StackFrame::Id id = isolate->debug()->break_frame_id();
   if (id == StackFrame::NO_ID) {
     // If there is no JavaScript stack frame count is 0.
-    return Smi::kZero;
+    return Smi::FromInt(0);
   }
 
   for (StackTraceFrameIterator it(isolate, id); !it.done(); it.Advance()) {
     List<FrameSummary> frames(FLAG_max_inlining_levels + 1);
     if (it.is_wasm()) {
       n++;
     } else {
       it.javascript_frame()->Summarize(&frames);
       for (int i = frames.length() - 1; i >= 0; i--) {
         // Omit functions from native and extension scripts.
@@ skipping 85 matching lines @@
     Handle<String> func_name =
         wasm::GetWasmFunctionName(isolate, wasm_obj, func_index);
     details->set(kFrameDetailsFunctionIndex, *func_name);
 
     // Add the script wrapper
     Handle<Object> script_wrapper =
         Script::GetWrapper(frame_inspector.GetScript());
     details->set(kFrameDetailsScriptIndex, *script_wrapper);
 
     // Add the arguments count.
-    details->set(kFrameDetailsArgumentCountIndex, Smi::kZero);
+    details->set(kFrameDetailsArgumentCountIndex, Smi::FromInt(0));
 
     // Add the locals count
-    details->set(kFrameDetailsLocalCountIndex, Smi::kZero);
+    details->set(kFrameDetailsLocalCountIndex, Smi::FromInt(0));
 
     // Add the source position.
     if (position != kNoSourcePosition) {
       details->set(kFrameDetailsSourcePositionIndex, Smi::FromInt(position));
     }
 
     // Add the constructor information.
     details->set(kFrameDetailsConstructCallIndex, heap->ToBoolean(false));
 
     // Add the at return information.
@@ skipping 342 matching lines @@
     return isolate->heap()->undefined_value();
   }
 
   RETURN_RESULT_OR_FAILURE(isolate, it.MaterializeScopeDetails());
 }
 
 RUNTIME_FUNCTION(Runtime_GetGeneratorScopeCount) {
   HandleScope scope(isolate);
   DCHECK_EQ(1, args.length());
 
-  if (!args[0]->IsJSGeneratorObject()) return Smi::kZero;
+  if (!args[0]->IsJSGeneratorObject()) return Smi::FromInt(0);
 
   // Check arguments.
   CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, gen, 0);
 
   // Count the visible scopes.
   int n = 0;
   for (ScopeIterator it(isolate, gen); !it.Done(); it.Next()) {
     n++;
   }
 
@@ skipping 651 matching lines @@
 
   Script::InitLineEnds(script_handle);
 
   FixedArray* line_ends_array = FixedArray::cast(script_handle->line_ends());
   const int line_count = line_ends_array->length();
 
   // If line == line_count, we return the first position beyond the last line.
   if (line < 0 || line > line_count) {
     return Smi::FromInt(-1);
   } else if (line == 0) {
-    return Smi::kZero;
+    return Smi::FromInt(0);
   } else {
     DCHECK(0 < line && line <= line_count);
     const int pos = Smi::cast(line_ends_array->get(line - 1))->value() + 1;
     return Smi::FromInt(pos);
   }
 }
 
 RUNTIME_FUNCTION(Runtime_ScriptLineEndPosition) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 2);
@@ skipping 252 matching lines @@
   Handle<Script> script = Handle<Script>(Script::cast(script_val->value()));
 
   Handle<wasm::WasmDebugInfo> debug_info =
       wasm::GetDebugInfo(handle(script->wasm_object(), isolate));
   return *wasm::WasmDebugInfo::DisassembleFunction(
       debug_info, script->wasm_function_index());
 }
 
 }  // namespace internal
 }  // namespace v8