Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

src/full-codegen/s390/full-codegen-s390.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_S390
 
 #include "src/full-codegen/full-codegen.h"
 #include "src/ast/compile-time-value.h"
 #include "src/ast/scopes.h"
 #include "src/code-factory.h"
@@ skipping 345 matching lines @@
   // Always emit a 'return undefined' in case control fell off the end of
   // the body.
   {
     Comment cmnt(masm_, "[ return <undefined>;");
     __ LoadRoot(r2, Heap::kUndefinedValueRootIndex);
   }
   EmitReturnSequence();
 }
 
 void FullCodeGenerator::ClearAccumulator() {
-  __ LoadSmiLiteral(r2, Smi::kZero);
+  __ LoadSmiLiteral(r2, Smi::FromInt(0));
 }
 
 void FullCodeGenerator::EmitProfilingCounterDecrement(int delta) {
   __ mov(r4, Operand(profiling_counter_));
   intptr_t smi_delta = reinterpret_cast<intptr_t>(Smi::FromInt(delta));
   if (CpuFeatures::IsSupported(GENERAL_INSTR_EXT) && is_int8(-smi_delta)) {
     __ AddP(FieldMemOperand(r4, Cell::kValueOffset), Operand(-smi_delta));
     __ LoadP(r5, FieldMemOperand(r4, Cell::kValueOffset));
   } else {
     __ LoadP(r5, FieldMemOperand(r4, Cell::kValueOffset));
@@ skipping 600 matching lines @@
   Label fixed_array;
   __ LoadP(r4, FieldMemOperand(r2, HeapObject::kMapOffset));
   __ CompareRoot(r4, Heap::kMetaMapRootIndex);
   __ bne(&fixed_array);
 
   // We got a map in register r2. Get the enumeration cache from it.
   Label no_descriptors;
   __ bind(&use_cache);
 
   __ EnumLength(r3, r2);
-  __ CmpSmiLiteral(r3, Smi::kZero, r0);
+  __ CmpSmiLiteral(r3, Smi::FromInt(0), r0);
   __ beq(&no_descriptors, Label::kNear);
 
   __ LoadInstanceDescriptors(r2, r4);
   __ LoadP(r4, FieldMemOperand(r4, DescriptorArray::kEnumCacheOffset));
   __ LoadP(r4,
            FieldMemOperand(r4, DescriptorArray::kEnumCacheBridgeCacheOffset));
 
   // Set up the four remaining stack slots.
   __ push(r2);  // Map.
-  __ LoadSmiLiteral(r2, Smi::kZero);
+  __ LoadSmiLiteral(r2, Smi::FromInt(0));
   // Push enumeration cache, enumeration cache length (as smi) and zero.
   __ Push(r4, r3, r2);
   __ b(&loop);
 
   __ bind(&no_descriptors);
   __ Drop(1);
   __ b(&exit);
 
   // We got a fixed array in register r2. Iterate through that.
   __ bind(&fixed_array);
 
   __ LoadSmiLiteral(r3, Smi::FromInt(1));  // Smi(1) indicates slow check
   __ Push(r3, r2);                         // Smi and array
   __ LoadP(r3, FieldMemOperand(r2, FixedArray::kLengthOffset));
   __ Push(r3);  // Fixed array length (as smi).
   PrepareForBailoutForId(stmt->PrepareId(), BailoutState::NO_REGISTERS);
-  __ LoadSmiLiteral(r2, Smi::kZero);
+  __ LoadSmiLiteral(r2, Smi::FromInt(0));
   __ Push(r2);  // Initial index.
 
   // Generate code for doing the condition check.
   __ bind(&loop);
   SetExpressionAsStatementPosition(stmt->each());
 
   // Load the current count to r2, load the length to r3.
   __ LoadP(r2, MemOperand(sp, 0 * kPointerSize));
   __ LoadP(r3, MemOperand(sp, 1 * kPointerSize));
   __ CmpLogicalP(r2, r3);  // Compare to the array length.
@@ skipping 864 matching lines @@
 #else
       __ LoadRR(right, scratch2);
 #endif
       __ b(&done);
       // We need -0 if we were multiplying a negative number with 0 to get 0.
       // We know one of them was zero.
       __ bind(&mul_zero);
       __ AddP(scratch2, right, left);
       __ CmpP(scratch2, Operand::Zero());
       __ blt(&stub_call);
-      __ LoadSmiLiteral(right, Smi::kZero);
+      __ LoadSmiLiteral(right, Smi::FromInt(0));
       break;
     }
     case Token::BIT_OR:
       __ OrP(right, left);
       break;
     case Token::BIT_AND:
       __ AndP(right, left);
       break;
     case Token::BIT_XOR:
       __ XorP(right, left);
@@ skipping 1078 matching lines @@
   LhsKind assign_type = Property::GetAssignType(prop);
 
   // Evaluate expression and get value.
   if (assign_type == VARIABLE) {
     DCHECK(expr->expression()->AsVariableProxy()->var() != NULL);
     AccumulatorValueContext context(this);
     EmitVariableLoad(expr->expression()->AsVariableProxy());
   } else {
     // Reserve space for result of postfix operation.
     if (expr->is_postfix() && !context()->IsEffect()) {
-      __ LoadSmiLiteral(ip, Smi::kZero);
+      __ LoadSmiLiteral(ip, Smi::FromInt(0));
       PushOperand(ip);
     }
     switch (assign_type) {
       case NAMED_PROPERTY: {
         // Put the object both on the stack and in the register.
         VisitForStackValue(prop->obj());
         __ LoadP(LoadDescriptor::ReceiverRegister(), MemOperand(sp, 0));
         EmitNamedPropertyLoad(prop);
         break;
       }
@@ skipping 562 matching lines @@
   DCHECK(kOSRBranchInstruction == br_instr);
 
   DCHECK(interrupt_address ==
          isolate->builtins()->OnStackReplacement()->entry());
   return ON_STACK_REPLACEMENT;
 }
 
 }  // namespace internal
 }  // namespace v8
 #endif  // V8_TARGET_ARCH_S390