Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: src/debug/debug.h

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/date.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_H_ 5 #ifndef V8_DEBUG_DEBUG_H_
6 #define V8_DEBUG_DEBUG_H_ 6 #define V8_DEBUG_DEBUG_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 } 562 }
563 563
564 // Check whether there are commands in the command queue. 564 // Check whether there are commands in the command queue.
565 inline bool has_commands() const { return !command_queue_.IsEmpty(); } 565 inline bool has_commands() const { return !command_queue_.IsEmpty(); }
566 inline bool ignore_events() const { return is_suppressed_ || !is_active_; } 566 inline bool ignore_events() const { return is_suppressed_ || !is_active_; }
567 inline bool break_disabled() const { 567 inline bool break_disabled() const {
568 return break_disabled_ || in_debug_event_listener_; 568 return break_disabled_ || in_debug_event_listener_;
569 } 569 }
570 570
571 void clear_suspended_generator() { 571 void clear_suspended_generator() {
572 thread_local_.suspended_generator_ = Smi::kZero; 572 thread_local_.suspended_generator_ = Smi::FromInt(0);
573 } 573 }
574 574
575 bool has_suspended_generator() const { 575 bool has_suspended_generator() const {
576 return thread_local_.suspended_generator_ != Smi::kZero; 576 return thread_local_.suspended_generator_ != Smi::FromInt(0);
577 } 577 }
578 578
579 void OnException(Handle<Object> exception, Handle<Object> promise); 579 void OnException(Handle<Object> exception, Handle<Object> promise);
580 580
581 // Constructors for debug event objects. 581 // Constructors for debug event objects.
582 MUST_USE_RESULT MaybeHandle<Object> MakeExecutionState(); 582 MUST_USE_RESULT MaybeHandle<Object> MakeExecutionState();
583 MUST_USE_RESULT MaybeHandle<Object> MakeBreakEvent( 583 MUST_USE_RESULT MaybeHandle<Object> MakeBreakEvent(
584 Handle<Object> break_points_hit); 584 Handle<Object> break_points_hit);
585 MUST_USE_RESULT MaybeHandle<Object> MakeExceptionEvent( 585 MUST_USE_RESULT MaybeHandle<Object> MakeExceptionEvent(
586 Handle<Object> exception, 586 Handle<Object> exception,
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 Handle<Code> code); 818 Handle<Code> code);
819 static bool DebugBreakSlotIsPatched(Address pc); 819 static bool DebugBreakSlotIsPatched(Address pc);
820 static void ClearDebugBreakSlot(Isolate* isolate, Address pc); 820 static void ClearDebugBreakSlot(Isolate* isolate, Address pc);
821 }; 821 };
822 822
823 823
824 } // namespace internal 824 } // namespace internal
825 } // namespace v8 825 } // namespace v8
826 826
827 #endif // V8_DEBUG_DEBUG_H_ 827 #endif // V8_DEBUG_DEBUG_H_
OLDNEW
« no previous file with comments | « src/date.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698