Issue 2396323004: Bug fix - use type of input, not type of result, for throw-on-null check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2396323004: Bug fix - use type of input, not type of result, for throw-on-null check (Closed)

Created:
4 years, 2 months ago by sra1

Modified:
4 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/ssa/nodes.dart	View		1 chunk	+8 lines, -2 lines	0 comments	Download
	M	tests/compiler/dart2js/js_spec_optimization_test.dart	View		2 chunks	+29 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

lgtm - I'm surprised we didn't hit this earlier

4 years, 2 months ago (2016-10-07 22:32:59 UTC) #3

sra1

4 years, 2 months ago (2016-10-09 07:32:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e60fee914a52ab27355938f63246e0eed122f8b5 (presubmit successful).