Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2396323003: [Remoting Android] Talkback confirmation for changing account (Closed)

Created:
4 years, 2 months ago by Yuwei
Modified:
4 years, 2 months ago
Reviewers:
Lambros
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Talkback confirmation for changing account This CL adds a talkback confirmation when the user changes the login account. BUG=650772 Committed: https://crrev.com/b492b6c52b7a0aa5c9683bdde19f4b807c36efee Cr-Commit-Position: refs/heads/master@{#424274}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Reviewer's Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yuwei
PTAL https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode609 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:609: String logInAnnouncement = getString(R.string.log_in_account_description, accountName); Just double check ...
4 years, 2 months ago (2016-10-07 19:16:30 UTC) #2
Lambros
https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode609 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:609: String logInAnnouncement = getString(R.string.log_in_account_description, accountName); On 2016/10/07 19:16:30, Yuwei ...
4 years, 2 months ago (2016-10-07 20:46:22 UTC) #3
Yuwei
PTAL https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode609 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:609: String logInAnnouncement = getString(R.string.log_in_account_description, accountName); On 2016/10/07 20:46:22, ...
4 years, 2 months ago (2016-10-10 21:43:32 UTC) #4
Lambros
lgtm
4 years, 2 months ago (2016-10-10 22:25:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396323003/20001
4 years, 2 months ago (2016-10-10 22:28:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 23:03:12 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 23:04:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b492b6c52b7a0aa5c9683bdde19f4b807c36efee
Cr-Commit-Position: refs/heads/master@{#424274}

Powered by Google App Engine
This is Rietveld 408576698