[Remoting Android] Talkback confirmation for changing account

[Remoting Android] Talkback confirmation for changing account

This CL adds a talkback confirmation when the user changes the login account.

BUG=650772
Committed: https://crrev.com/b492b6c52b7a0aa5c9683bdde19f4b807c36efee
Cr-Commit-Position: refs/heads/master@{#424274}

[Yuwei, 2016-10-07 19:16:29]

yuweih@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Yuwei, 2016-10-07 19:16:30]

PTAL

https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:609: String
logInAnnouncement = getString(R.string.log_in_account_description, accountName);
Just double check to be safe. Will accountName ever be null or empty string in
special situation like no account is available?

[Lambros, 2016-10-07 20:46:22]

https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:609: String
logInAnnouncement = getString(R.string.log_in_account_description, accountName);
On 2016/10/07 19:16:30, Yuwei wrote:
> Just double check to be safe. Will accountName ever be null or empty string in
> special situation like no account is available?

This is OK - onAccountSelected() should never be called with a null account. If
there are no accounts, we show a warning dialog then close the Activity.

https://codereview.chromium.org/2396323003/diff/1/remoting/resources/remoting...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/2396323003/diff/1/remoting/resources/remoting...
remoting/resources/remoting_strings.grd:1157: <message desc="Message announced
by Talkback when the user changes the log in account."
name="IDS_LOG_IN_ACCOUNT_DESCRIPTION" formatter_data="android_java">
The translators can only see the description and the English text - they have no
other context at all. They don't know that this string is part of an Android
app, and probably won't know what "Talkback" is.
Maybe something like:
"Message that is spoken (for accessibility) whenever the user selects an account
from a list displayed in the application."

https://codereview.chromium.org/2396323003/diff/1/remoting/resources/remoting...
remoting/resources/remoting_strings.grd:1158: Logged in as <ph
name="EMAIL_ADDRESS">%1$s<ex>test@gmail.com</ex></ph>.
Do we prefer "Logged in" or "Signed in" ? Can you try to find out what other
Google apps do?

[Yuwei, 2016-10-10 21:43:32]

PTAL

https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/2396323003/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:609: String
logInAnnouncement = getString(R.string.log_in_account_description, accountName);
On 2016/10/07 20:46:22, Lambros wrote:
> On 2016/10/07 19:16:30, Yuwei wrote:
> > Just double check to be safe. Will accountName ever be null or empty string
in
> > special situation like no account is available?
> 
> This is OK - onAccountSelected() should never be called with a null account.
If
> there are no accounts, we show a warning dialog then close the Activity.

Acknowledged.

https://codereview.chromium.org/2396323003/diff/1/remoting/resources/remoting...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/2396323003/diff/1/remoting/resources/remoting...
remoting/resources/remoting_strings.grd:1157: <message desc="Message announced
by Talkback when the user changes the log in account."
name="IDS_LOG_IN_ACCOUNT_DESCRIPTION" formatter_data="android_java">
On 2016/10/07 20:46:22, Lambros wrote:
> The translators can only see the description and the English text - they have
no
> other context at all. They don't know that this string is part of an Android
> app, and probably won't know what "Talkback" is.
> Maybe something like:
> "Message that is spoken (for accessibility) whenever the user selects an
account
> from a list displayed in the application."

Done.

https://codereview.chromium.org/2396323003/diff/1/remoting/resources/remoting...
remoting/resources/remoting_strings.grd:1158: Logged in as <ph
name="EMAIL_ADDRESS">%1$s<ex>test@gmail.com</ex></ph>.
On 2016/10/07 20:46:22, Lambros wrote:
> Do we prefer "Logged in" or "Signed in" ? Can you try to find out what other
> Google apps do?

It looks like chromium mostly uses "Signed in as" in strings. See:
https://cs.chromium.org/search/?q=signed%5C+in%5C+as&sq=package:chromium&type=cs

Changed to "Signed in" for now. I think it's better than "Logged in"..?

[Lambros, 2016-10-10 22:25:07]

lgtm

[Yuwei, 2016-10-10 22:27:55]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-10-10 22:28:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 23:03:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-10 23:04:47]

Description was changed from

==========
[Remoting Android] Talkback confirmation for changing account

This CL adds a talkback confirmation when the user changes the login account.

BUG=650772
==========

to

==========
[Remoting Android] Talkback confirmation for changing account

This CL adds a talkback confirmation when the user changes the login account.

BUG=650772

Committed: https://crrev.com/b492b6c52b7a0aa5c9683bdde19f4b807c36efee
Cr-Commit-Position: refs/heads/master@{#424274}
==========

[commit-bot: I haz the power, 2016-10-10 23:04:48]

Patchset 2 (id:??) landed as
https://crrev.com/b492b6c52b7a0aa5c9683bdde19f4b807c36efee
Cr-Commit-Position: refs/heads/master@{#424274}