Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2396303002: Fix syntax of FlagExpectations/site-per-process (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, skobes
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix syntax of FlagExpectations/site-per-process In preparation for linting all flag expectations files, this patch fixes the syntax of FlagExpectations/site-per-process. BUG=644435 Committed: https://crrev.com/f78775a0c38ec507ee61f5e062151c3108c7a1fc Cr-Commit-Position: refs/heads/master@{#423932}

Patch Set 1 #

Patch Set 2 : Fix merge conflict with patch that landed yesterday #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -99 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 1 chunk +99 lines, -99 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pdr.
4 years, 2 months ago (2016-10-07 06:08:53 UTC) #2
chrishtr
lgtm
4 years, 2 months ago (2016-10-07 18:11:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396303002/1
4 years, 2 months ago (2016-10-07 18:13:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/276605) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-07 18:16:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396303002/20001
4 years, 2 months ago (2016-10-07 18:25:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 19:35:07 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 19:38:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f78775a0c38ec507ee61f5e062151c3108c7a1fc
Cr-Commit-Position: refs/heads/master@{#423932}

Powered by Google App Engine
This is Rietveld 408576698