Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2396253002: Finish AppTasks on UI thread during test tear down (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finish AppTasks on UI thread during test tear down Finish AppTasks on the UI thread rather than the insturmentation thread during test setup and tear down. Also eclose the finishAndRemoveTask() calls in a try-catch block so that otherwise passing tests don't fail on Android framework exceptions. BUG=653731 Committed: https://crrev.com/3a6e675bcca631ad83cd0dd7412c87297467bcda Cr-Commit-Position: refs/heads/master@{#423759}

Patch Set 1 #

Patch Set 2 : Finish AppTasks on UI thread during test tear down #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java View 1 1 chunk +17 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Theresa
ptal
4 years, 2 months ago (2016-10-07 00:00:16 UTC) #5
Ted C
lgtm
4 years, 2 months ago (2016-10-07 00:08:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396253002/20001
4 years, 2 months ago (2016-10-07 00:09:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 00:28:10 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 00:32:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a6e675bcca631ad83cd0dd7412c87297467bcda
Cr-Commit-Position: refs/heads/master@{#423759}

Powered by Google App Engine
This is Rietveld 408576698