Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2396243002: Revert of Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
Reviewers:
carlosk, gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices (patchset #1 id:1 of https://codereview.chromium.org/2397573008/ ) Reason for revert: Root cause is in Android framework, we're just going to catch the exception Original issue's description: > Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices > > BUG=653685 > TBR=carlosk@chromium.org, dfalcantara@chromium.org > > Committed: https://crrev.com/3988c1fd1bc405d01850a8e5e28619d0630b5184 > Cr-Commit-Position: refs/heads/master@{#423709} TBR=carlosk@chromium.org,dfalcantara@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653685 Committed: https://crrev.com/e2ea1d095f632eaec0efda57fd6e0525e83299ac Cr-Commit-Position: refs/heads/master@{#423743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Theresa
Created Revert of Restrict ModalDialogTest#testPromptModalDialog to non-low-end devices
4 years, 2 months ago (2016-10-06 23:45:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396243002/1
4 years, 2 months ago (2016-10-06 23:45:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 23:46:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2ea1d095f632eaec0efda57fd6e0525e83299ac Cr-Commit-Position: refs/heads/master@{#423743}
4 years, 2 months ago (2016-10-06 23:48:22 UTC) #7
carlosk
4 years, 2 months ago (2016-10-07 01:24:06 UTC) #8
Message was sent while issue was closed.
LGTM as well (again for the record).

Powered by Google App Engine
This is Rietveld 408576698