Issue 239623002: Revert of rebaseline_server: multithreaded loading/diffing of images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239623002: Revert of rebaseline_server: multithreaded loading/diffing of images (Closed)

Created:
6 years, 8 months ago by epoger

Modified:
6 years, 8 months ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of rebaseline_server: multithreaded loading/diffing of images (https://codereview.chromium.org/235923002/) Reason for revert: Caused https://code.google.com/p/skia/issues/detail?id=2423 ('"Deadline exceeded" error when connecting to live rebaseline_server'). Reverting until I can figure it out. Original issue's description: > rebaseline_server: multithreaded loading/diffing of images > > BUG=skia:2414 > NOTRY=True > > Committed: http://code.google.com/p/skia/source/detail?r=14184 TBR=rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2414 Committed: http://code.google.com/p/skia/source/detail?r=14207

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -192 lines)			Patch
M	gm/rebaseline_server/compare_to_expectations.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gm/rebaseline_server/imagediffdb.py	View	11 chunks	+22 lines, -153 lines	0 comments	Download
M	gm/rebaseline_server/imagepair.py	View	2 chunks	+16 lines, -33 lines	0 comments	Download
M	gm/rebaseline_server/imagepairset.py	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

epoger

Created Revert of rebaseline_server: multithreaded loading/diffing of images

6 years, 8 months ago (2014-04-15 18:49:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/239623002/1

6 years, 8 months ago (2014-04-15 18:50:04 UTC) #2

Message was sent while issue was closed.

Change committed as 14207