[inspector] move changeBreakpointState from debugger-script to native

include/v8-debug.h

Index: include/v8-debug.h
diff --git a/include/v8-debug.h b/include/v8-debug.h
index 6385a31d85e80f53e516b770812e6b0385ed5fe7..4e5991fa98d72a3dd7ffe6ade8b941336aed22fb 100644
--- a/include/v8-debug.h
+++ b/include/v8-debug.h
@@ -23,6 +23,12 @@ enum DebugEvent {
   AsyncTaskEvent = 7,
 };
 
+enum ExceptionBreakState {
+  NoBreakOnException = 0,
+  BreakOnUncaughtException = 1,
+  BreakOnAnyException = 2
+};
+
 class V8_EXPORT Debug {
  public:
   /**
@@ -275,6 +281,15 @@ class V8_EXPORT Debug {
    */
   static bool IsTailCallEliminationEnabled(Isolate* isolate);
   static void SetTailCallEliminationEnabled(Isolate* isolate, bool enabled);
+
+  /**
+   * Defines if VM will pause on exceptions or not.
+   * If BreakOnAnyExceptions is set then VM will pause on caught and uncaught
+   * exception, if BreakOnUncaughtException is set then VM will pause only on
+   * uncaught exception, otherwise VM won't stop on any exception.
+   */
+  static void ChangeBreakOnException(Isolate* isolate,

[dgozman, 2016/10/06 21:48:43]

I wonder whether we want new public C++ api for debugging. This patch moves api
from js to native, which is good in some way, but maybe we just want
"v8-inspector-only" api to avoid growing v8::Debug and leave wired protocol as
"the api" ?

Yang, what's your view on this? Should we discuss pros and cons of different
approaches (including existing status quo) and figure out a roadmap?

[Yang, 2016/10/07 14:05:55]

The idea that I have, but not really communicated yet, is to introduce a
src/debug/debug-api.h and src/debug/debug-api.cc as interface between inspector
and the debugger. Eventually, the inspector protocol should become the only
debugger API to outside of V8.

+                                     ExceptionBreakState state);
 };