[inspector] move changeBreakpointState from debugger-script to native

include/v8-debug.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_V8_DEBUG_H_
 #define V8_V8_DEBUG_H_
 
 #include "v8.h"  // NOLINT(build/include)
 
 /**
  * Debugger support for the V8 JavaScript engine.
  */
 namespace v8 {
 
 // Debug events which can occur in the V8 JavaScript engine.
 enum DebugEvent {
   Break = 1,
   Exception = 2,
   NewFunction = 3,
   BeforeCompile = 4,
   AfterCompile = 5,
   CompileError = 6,
   AsyncTaskEvent = 7,
 };
 
+enum ExceptionBreakState {
+  NoBreakOnException = 0,
+  BreakOnUncaughtException = 1,
+  BreakOnAnyException = 2
+};
+
 class V8_EXPORT Debug {
  public:
   /**
    * A client object passed to the v8 debugger whose ownership will be taken by
    * it. v8 is always responsible for deleting the object.
    */
   class ClientData {
    public:
     virtual ~ClientData() {}
   };
@@ skipping 232 matching lines @@
   static MaybeLocal<Array> GetInternalProperties(Isolate* isolate,
                                                  Local<Value> value);
 
   /**
    * Defines if the ES2015 tail call elimination feature is enabled or not.
    * The change of this flag triggers deoptimization of all functions that
    * contain calls at tail position.
    */
   static bool IsTailCallEliminationEnabled(Isolate* isolate);
   static void SetTailCallEliminationEnabled(Isolate* isolate, bool enabled);
+
+  /**
+   * Defines if VM will pause on exceptions or not.
+   * If BreakOnAnyExceptions is set then VM will pause on caught and uncaught
+   * exception, if BreakOnUncaughtException is set then VM will pause only on
+   * uncaught exception, otherwise VM won't stop on any exception.
+   */
+  static void ChangeBreakOnException(Isolate* isolate,

[dgozman, 2016/10/06 21:48:43]

I wonder whether we want new public C++ api for debugging. This patch moves api
from js to native, which is good in some way, but maybe we just want
"v8-inspector-only" api to avoid growing v8::Debug and leave wired protocol as
"the api" ?

Yang, what's your view on this? Should we discuss pros and cons of different
approaches (including existing status quo) and figure out a roadmap?

[Yang, 2016/10/07 14:05:55]

The idea that I have, but not really communicated yet, is to introduce a
src/debug/debug-api.h and src/debug/debug-api.cc as interface between inspector
and the debugger. Eventually, the inspector protocol should become the only
debugger API to outside of V8.

+                                     ExceptionBreakState state);
 };
 
 
 }  // namespace v8
 
 
 #undef EXPORT
 
 
 #endif  // V8_V8_DEBUG_H_