Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2396173003: Handle constructor declarations. (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle constructor declarations. + default values + if-null and set-if-null R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/090f20fc5d2e6050b048e65197a2537955b5bf7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -45 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 6 chunks +65 lines, -36 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 6 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 2 months ago (2016-10-07 14:24:53 UTC) #2
Harry Terkelsen
lgtm
4 years, 2 months ago (2016-10-07 16:03:03 UTC) #3
Johnni Winther
4 years, 2 months ago (2016-10-10 09:36:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
090f20fc5d2e6050b048e65197a2537955b5bf7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698