Adding Pinned Tab and Preferences-specified Tab logic to Startup Flow refactor

chrome/browser/ui/startup/startup_tab_provider_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_tab_provider.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/url_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
@@ skipping 49 matching lines @@
             output[0].url);
   EXPECT_FALSE(output[0].is_pinned);
 }
 
 TEST(StartupTabProviderTest, CheckResetTriggerTabPolicy_Negative) {
   StartupTabs output =
       StartupTabProviderImpl::CheckResetTriggerTabPolicy(false);
 
   ASSERT_TRUE(output.empty());
 }
+
+TEST(StartupTabProviderTest, CheckPreferencesTabPolicy) {
+  SessionStartupPref pref(SessionStartupPref::Type::URLS);
+  pref.urls = {GURL(base::ASCIIToUTF16("https://www.google.com"))};
+

[Peter Kasting, 2016/10/18 00:53:41]

Nit: No blank here?  (You don't do similar blanks in the next test)

[tmartino, 2016/10/19 22:01:29]

I did use blanks in the above tests, so I've added them below instead.

+  StartupTabs output = StartupTabProviderImpl::CheckPreferencesTabPolicy(pref);
+
+  ASSERT_EQ(1U, output.size());
+  EXPECT_EQ("www.google.com", output[0].url.host());
+}
+
+TEST(StartupTabProviderTest, CheckPreferencesTabPolicy_Negative) {
+  SessionStartupPref pref_default(SessionStartupPref::Type::DEFAULT);
+  pref_default.urls =
+      std::vector<GURL>({GURL(base::ASCIIToUTF16("https://www.google.com"))});

[Peter Kasting, 2016/10/18 00:53:41]

Nit: I think you can omit "std::vector<GURL>()" (2 places)

[tmartino, 2016/10/19 22:01:29]

Done

+  StartupTabs output =
+      StartupTabProviderImpl::CheckPreferencesTabPolicy(pref_default);
+
+  EXPECT_TRUE(output.empty());
+
+  SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
+  pref_last.urls =
+      std::vector<GURL>({GURL(base::ASCIIToUTF16("https://www.google.com"))});
+  output = StartupTabProviderImpl::CheckPreferencesTabPolicy(pref_last);
+
+  EXPECT_TRUE(output.empty());
+}