Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2396123002: Add IPC to notify BrowserPlugin when RenderProcess is ready. (Closed)

Created:
4 years, 2 months ago by wjmaclean
Modified:
4 years, 2 months ago
Reviewers:
kenrb
CC:
chromium-reviews, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IPC to notify BrowserPlugin when RenderProcess is ready. When a guest renderer crashes, and then is re-created via a navigation, the BrowserPlugin currently does not get notified, and thus cannot clear the guest_crashed_ flag. This causes the BrowserPlugin to ignore incoming input events. This CL adds an IPC to notify BrowserPlugin when it should clear guest_crashed_. BUG=653016 Committed: https://crrev.com/f73a79830396614b9429612b286dcf6b1df5a356 Cr-Commit-Position: refs/heads/master@{#423897}

Patch Set 1 #

Patch Set 2 : Only send BrowserPluginMsg_GuestReady if we're already attached. #

Total comments: 1

Patch Set 3 : Fix comment typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (14 generated)
wjmaclean
CL to run on the bots.
4 years, 2 months ago (2016-10-06 17:22:56 UTC) #3
kenrb
lgtm https://codereview.chromium.org/2396123002/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc File content/browser/browser_plugin/browser_plugin_guest.cc (right): https://codereview.chromium.org/2396123002/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc#newcode644 content/browser/browser_plugin/browser_plugin_guest.cc:644: // as the guest_crashed_ is cleared automaticall on ...
4 years, 2 months ago (2016-10-07 15:41:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396123002/40001
4 years, 2 months ago (2016-10-07 16:43:15 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-07 17:40:34 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 17:41:51 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f73a79830396614b9429612b286dcf6b1df5a356
Cr-Commit-Position: refs/heads/master@{#423897}

Powered by Google App Engine
This is Rietveld 408576698