Avoid a write to NULL in ReadFieldBinary

Avoid a write to NULL in ReadFieldBinary

what happens is that we use vector_as_array(&data) which returns null if data is empty, but we don't check |size| whichcan be 0 so data.resize(size) still an empty vector.

This is currently happening for browser_tests.exe in the waterfall.

There might be a better fix but lots of tests are having exceptions so I want to stop that.

TBR=mnissler
BUG=none
TEST=logs are clean

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222177

[cpu_(ooo_6.6-7.5), 2013-09-10 01:47:17]

this is what we see in the bots

Starting tests...
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Note: Google Test filter = NetInternalsTest.netInternalsTimelineViewScrollbar
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from NetInternalsTest, where TypeParam =
[ RUN      ] NetInternalsTest.netInternalsTimelineViewScrollbar
c:\program files (x86)\microsoft visual studio 10.0\vc\include\xutility(2237) :
Assertion failed: invalid null pointer
c:\program files (x86)\microsoft visual studio 10.0\vc\include\xutility(2237) :
Assertion failed: invalid null pointer
c:\program files (x86)\microsoft visual studio 10.0\vc\include\xutility(2237) :
Assertion failed: invalid null pointer
c:\program files (x86)\microsoft visual studio 10.0\vc\include\xutility(2237) :
Assertion failed: invalid null pointer
[9568:8432:0909/161913:2268554948:ERROR:chrome_views_delegate.cc(158)] NOT
IMPLEMENTED
[9568:8432:0909/161913:2268554948:ERROR:desktop_root_window_host_win.cc(668)]
NOT IMPLEMENTED
c:\program files (x86)\microsoft visual studio 10.0\vc\include\xutility(2237) :
Assertion failed: invalid null pointer
c:\program files (x86)\microsoft visual studio 10.0\vc\include\xutility(2237) :
Assertion failed: invalid null pointer
c:\program files (x86)\microsoft visual studio 10.0\vc\include\xutility(2237) :
Assertion failed: invalid null pointer
c:\program files (x86)\microsoft visual studio 10.0\vc\include\xutility(2237) :
Assertion failed: invalid null pointer
[8760:11136:0909/161914:ERROR:renderer_main.cc(227)] Running without renderer
sandbox

[cpu_(ooo_6.6-7.5), 2013-09-10 01:53:32]

Committed patchset #1 manually as r222177.

[Mattias Nissler (ping if slow), 2013-09-11 13:42:24]

Interesting. Do you happen to have preserved stack traces somewhere? This surely
needs a proper fix, but I'd be very interested to learn what triggered this as I
had never seen this problem before.