Adding V8 and process memory information as metrics that endure tracks

Adding V8 and process memory information as metrics that endure tracks

BUG=273827
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221658

[edmundyan, 2013-09-04 17:38:45]

We're ready to start adding more stats for endure to track.  Found the change by
rmcilroy (https://chromiumcodereview.appspot.com/23112028) and after discussing
with the V8 team, decided it would be useful for endure to track these counters.

The browser/renderer process memory stats should ideally be coming from some
internal browser API.  I don't think any are exposed to Telemetry yet.  Still, I
think tracking memory from a platform-level would be better than nothing.  Open
to suggestions here.

[tonyg, 2013-09-04 17:47:38]

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
File tools/perf/measurements/endure.py (right):

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:62:
options.AppendExtraBrowserArg('--no-sandbox')
If the metric needs this, the metric should be responsible for adding it.

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:84: _dom_stats = tab.dom_stats
No need to _ prefix local variables.

[Michael Achenbach, 2013-09-05 11:57:23]

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
File tools/perf/measurements/endure.py (right):

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:139: return sum([v for k, v in d.iteritems()
if k in keys_list])
How about:
[d[k] for k in keys_list]

or can there be missing keys?

[edmundyan, 2013-09-05 20:32:11]

Rebased with the changes made to the v8 metric. PTAL

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
File tools/perf/measurements/endure.py (right):

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:62:
options.AppendExtraBrowserArg('--no-sandbox')
On 2013/09/04 17:47:38, tonyg wrote:
> If the metric needs this, the metric should be responsible for adding it.

Done.

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:84: _dom_stats = tab.dom_stats
On 2013/09/04 17:47:38, tonyg wrote:
> No need to _ prefix local variables.

Done.

https://codereview.chromium.org/23961002/diff/1/tools/perf/measurements/endur...
tools/perf/measurements/endure.py:139: return sum([v for k, v in d.iteritems()
if k in keys_list])
On 2013/09/05 11:57:23, machenbach wrote:
> How about:
> [d[k] for k in keys_list]
> 
> or can there be missing keys?
There won't be missing keys.  If v8 can't find the counter specified, it will
return 0

[tonyg, 2013-09-05 21:05:50]

lgtm

[commit-bot: I haz the power, 2013-09-05 22:57:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/edmundyan@chromium.org/23961002/11001

[commit-bot: I haz the power, 2013-09-06 08:59:18]

Change committed as 221658