Add Notification images (Android pre-N standard layout)

Add Notification images (Android pre-N standard layout)

Previously images were only supported on desktop and Android Nougat;
they would be hidden on JellyBean through Marshmallow where we use a
custom layout for the notifications. This patch makes us use the
standard layout on all versions of Android when an image is present,
thus images are now supported everywhere.

Still behind the --enable-experimental-web-platform-features flag.

Intent to implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FQxPB5GEQjo/discussion

Screenshot: https://imgur.com/a/A7VzK

Depends on https://codereview.chromium.org/2273033002

BUG=614456
Committed: https://crrev.com/edbb2648f4de98d287a5a65d3b16832f4fedf6a2
Cr-Commit-Position: refs/heads/master@{#423616}

[johnme, 2016-10-06 14:28:30]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-10-06 14:49:44]

lgtm w/ test

https://codereview.chromium.org/2396063002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
(right):

https://codereview.chromium.org/2396063002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:629:
// standard notification.
Please document this in the method-level docblock as opposed to here.

[johnme, 2016-10-06 18:21:00]

Addressed review comments - thanks!

> lgtm w/ test

Added test.

https://codereview.chromium.org/2396063002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
(right):

https://codereview.chromium.org/2396063002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:629:
// standard notification.
On 2016/10/06 14:49:44, Peter Beverloo wrote:
> Please document this in the method-level docblock as opposed to here.

Done (though it seems odd to explain the implementation in the interface
comment).

[johnme, 2016-10-06 18:21:22]

The CQ bit was checked by johnme@chromium.org

[johnme, 2016-10-06 18:21:23]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2396063002/#ps20001
(title: "Add test and move comment")

[commit-bot: I haz the power, 2016-10-06 18:22:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 19:06:24]

Description was changed from

==========
Add Notification images (Android pre-N standard layout)

Previously images were only supported on desktop and Android Nougat;
they would be hidden on JellyBean through Marshmallow where we use a
custom layout for the notifications. This patch makes us use the
standard layout on all versions of Android when an image is present,
thus images are now supported everywhere.

Still behind the --enable-experimental-web-platform-features flag.

Intent to implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FQxPB5GEQjo/discus...

Screenshot: https://imgur.com/a/A7VzK

Depends on https://codereview.chromium.org/2273033002

BUG=614456
==========

to

==========
Add Notification images (Android pre-N standard layout)

Previously images were only supported on desktop and Android Nougat;
they would be hidden on JellyBean through Marshmallow where we use a
custom layout for the notifications. This patch makes us use the
standard layout on all versions of Android when an image is present,
thus images are now supported everywhere.

Still behind the --enable-experimental-web-platform-features flag.

Intent to implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FQxPB5GEQjo/discus...

Screenshot: https://imgur.com/a/A7VzK

Depends on https://codereview.chromium.org/2273033002

BUG=614456

Committed: https://crrev.com/edbb2648f4de98d287a5a65d3b16832f4fedf6a2
Cr-Commit-Position: refs/heads/master@{#423616}
==========

[commit-bot: I haz the power, 2016-10-06 19:06:25]

Patchset 2 (id:??) landed as
https://crrev.com/edbb2648f4de98d287a5a65d3b16832f4fedf6a2
Cr-Commit-Position: refs/heads/master@{#423616}

[commit-bot: I haz the power, 2016-10-06 19:06:42]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean