Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 239603002: Only build win static_initializers tool on Pro where DIA is available (Closed)

Created:
6 years, 8 months ago by scottmg
Modified:
6 years, 8 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Visibility:
Public.

Description

Only build win static_initializers tool on Pro where DIA is available Otherwise, 'all' fails when using Express toolchain. R=grt@chromium.org BUG=https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/j5xzCWuwam4 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264305

Patch Set 1 #

Total comments: 2

Patch Set 2 : msvs_express #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M tools/win/static_initializers/static_initializers.gyp View 1 1 chunk +17 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 8 months ago (2014-04-15 18:15:18 UTC) #1
grt (UTC plus 2)
lgtm if the answer to my question below is "no". https://codereview.chromium.org/239603002/diff/1/tools/win/static_initializers/static_initializers.gyp File tools/win/static_initializers/static_initializers.gyp (right): https://codereview.chromium.org/239603002/diff/1/tools/win/static_initializers/static_initializers.gyp#newcode10 ...
6 years, 8 months ago (2014-04-16 15:06:42 UTC) #2
scottmg
https://codereview.chromium.org/239603002/diff/1/tools/win/static_initializers/static_initializers.gyp File tools/win/static_initializers/static_initializers.gyp (right): https://codereview.chromium.org/239603002/diff/1/tools/win/static_initializers/static_initializers.gyp#newcode10 tools/win/static_initializers/static_initializers.gyp:10: ['MSVS_VERSION=="2013"', { On 2014/04/16 15:06:43, grt wrote: > can ...
6 years, 8 months ago (2014-04-16 17:09:03 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 8 months ago (2014-04-16 17:09:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/239603002/20001
6 years, 8 months ago (2014-04-16 17:10:52 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 21:15:58 UTC) #6
Message was sent while issue was closed.
Change committed as 264305

Powered by Google App Engine
This is Rietveld 408576698