Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/crankshaft/x87/lithium-x87.cc

Issue 2396023002: [crankshaft] Remove HLoadGlobalGeneric and use HCallWithDescriptor instead to call LoadGlobalIC. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x87/lithium-x87.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/x87/lithium-x87.h" 5 #include "src/crankshaft/x87/lithium-x87.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_X87 9 #if V8_TARGET_ARCH_X87
10 10
(...skipping 1985 matching lines...) Expand 10 before | Expand all | Expand 10 after
1996 return DefineAsRegister(new(zone()) LConstantE); 1996 return DefineAsRegister(new(zone()) LConstantE);
1997 } else if (r.IsTagged()) { 1997 } else if (r.IsTagged()) {
1998 return DefineAsRegister(new(zone()) LConstantT); 1998 return DefineAsRegister(new(zone()) LConstantT);
1999 } else { 1999 } else {
2000 UNREACHABLE(); 2000 UNREACHABLE();
2001 return NULL; 2001 return NULL;
2002 } 2002 }
2003 } 2003 }
2004 2004
2005 2005
2006 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
2007 LOperand* context = UseFixed(instr->context(), esi);
2008 LOperand* vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2009
2010 LLoadGlobalGeneric* result = new (zone()) LLoadGlobalGeneric(context, vector);
2011 return MarkAsCall(DefineFixed(result, eax), instr);
2012 }
2013
2014
2015 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 2006 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
2016 LOperand* context = UseRegisterAtStart(instr->value()); 2007 LOperand* context = UseRegisterAtStart(instr->value());
2017 LInstruction* result = 2008 LInstruction* result =
2018 DefineAsRegister(new(zone()) LLoadContextSlot(context)); 2009 DefineAsRegister(new(zone()) LLoadContextSlot(context));
2019 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) { 2010 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) {
2020 result = AssignEnvironment(result); 2011 result = AssignEnvironment(result);
2021 } 2012 }
2022 return result; 2013 return result;
2023 } 2014 }
2024 2015
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
2522 LOperand* index = UseTempRegister(instr->index()); 2513 LOperand* index = UseTempRegister(instr->index());
2523 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2514 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2524 LInstruction* result = DefineSameAsFirst(load); 2515 LInstruction* result = DefineSameAsFirst(load);
2525 return AssignPointerMap(result); 2516 return AssignPointerMap(result);
2526 } 2517 }
2527 2518
2528 } // namespace internal 2519 } // namespace internal
2529 } // namespace v8 2520 } // namespace v8
2530 2521
2531 #endif // V8_TARGET_ARCH_X87 2522 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/crankshaft/x87/lithium-x87.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698