Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: src/crankshaft/x64/lithium-x64.cc

Issue 2396023002: [crankshaft] Remove HLoadGlobalGeneric and use HCallWithDescriptor instead to call LoadGlobalIC. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x64/lithium-x64.h ('k') | src/crankshaft/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/x64/lithium-x64.h" 5 #include "src/crankshaft/x64/lithium-x64.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_X64 9 #if V8_TARGET_ARCH_X64
10 10
(...skipping 1966 matching lines...) Expand 10 before | Expand all | Expand 10 after
1977 return DefineAsRegister(new(zone()) LConstantE); 1977 return DefineAsRegister(new(zone()) LConstantE);
1978 } else if (r.IsTagged()) { 1978 } else if (r.IsTagged()) {
1979 return DefineAsRegister(new(zone()) LConstantT); 1979 return DefineAsRegister(new(zone()) LConstantT);
1980 } else { 1980 } else {
1981 UNREACHABLE(); 1981 UNREACHABLE();
1982 return NULL; 1982 return NULL;
1983 } 1983 }
1984 } 1984 }
1985 1985
1986 1986
1987 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
1988 LOperand* context = UseFixed(instr->context(), rsi);
1989 LOperand* vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
1990
1991 LLoadGlobalGeneric* result = new (zone()) LLoadGlobalGeneric(context, vector);
1992 return MarkAsCall(DefineFixed(result, rax), instr);
1993 }
1994
1995
1996 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 1987 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
1997 LOperand* context = UseRegisterAtStart(instr->value()); 1988 LOperand* context = UseRegisterAtStart(instr->value());
1998 LInstruction* result = 1989 LInstruction* result =
1999 DefineAsRegister(new(zone()) LLoadContextSlot(context)); 1990 DefineAsRegister(new(zone()) LLoadContextSlot(context));
2000 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) { 1991 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) {
2001 result = AssignEnvironment(result); 1992 result = AssignEnvironment(result);
2002 } 1993 }
2003 return result; 1994 return result;
2004 } 1995 }
2005 1996
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
2525 LOperand* index = UseTempRegister(instr->index()); 2516 LOperand* index = UseTempRegister(instr->index());
2526 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2517 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2527 LInstruction* result = DefineSameAsFirst(load); 2518 LInstruction* result = DefineSameAsFirst(load);
2528 return AssignPointerMap(result); 2519 return AssignPointerMap(result);
2529 } 2520 }
2530 2521
2531 } // namespace internal 2522 } // namespace internal
2532 } // namespace v8 2523 } // namespace v8
2533 2524
2534 #endif // V8_TARGET_ARCH_X64 2525 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/crankshaft/x64/lithium-x64.h ('k') | src/crankshaft/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698