Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: src/crankshaft/ia32/lithium-ia32.cc

Issue 2396023002: [crankshaft] Remove HLoadGlobalGeneric and use HCallWithDescriptor instead to call LoadGlobalIC. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ia32/lithium-ia32.h ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/ia32/lithium-ia32.h" 5 #include "src/crankshaft/ia32/lithium-ia32.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_IA32 9 #if V8_TARGET_ARCH_IA32
10 10
(...skipping 1989 matching lines...) Expand 10 before | Expand all | Expand 10 after
2000 return DefineAsRegister(new(zone()) LConstantE); 2000 return DefineAsRegister(new(zone()) LConstantE);
2001 } else if (r.IsTagged()) { 2001 } else if (r.IsTagged()) {
2002 return DefineAsRegister(new(zone()) LConstantT); 2002 return DefineAsRegister(new(zone()) LConstantT);
2003 } else { 2003 } else {
2004 UNREACHABLE(); 2004 UNREACHABLE();
2005 return NULL; 2005 return NULL;
2006 } 2006 }
2007 } 2007 }
2008 2008
2009 2009
2010 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
2011 LOperand* context = UseFixed(instr->context(), esi);
2012 LOperand* vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2013
2014 LLoadGlobalGeneric* result = new (zone()) LLoadGlobalGeneric(context, vector);
2015 return MarkAsCall(DefineFixed(result, eax), instr);
2016 }
2017
2018
2019 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 2010 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
2020 LOperand* context = UseRegisterAtStart(instr->value()); 2011 LOperand* context = UseRegisterAtStart(instr->value());
2021 LInstruction* result = 2012 LInstruction* result =
2022 DefineAsRegister(new(zone()) LLoadContextSlot(context)); 2013 DefineAsRegister(new(zone()) LLoadContextSlot(context));
2023 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) { 2014 if (instr->RequiresHoleCheck() && instr->DeoptimizesOnHole()) {
2024 result = AssignEnvironment(result); 2015 result = AssignEnvironment(result);
2025 } 2016 }
2026 return result; 2017 return result;
2027 } 2018 }
2028 2019
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
2520 LOperand* index = UseTempRegister(instr->index()); 2511 LOperand* index = UseTempRegister(instr->index());
2521 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2512 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2522 LInstruction* result = DefineSameAsFirst(load); 2513 LInstruction* result = DefineSameAsFirst(load);
2523 return AssignPointerMap(result); 2514 return AssignPointerMap(result);
2524 } 2515 }
2525 2516
2526 } // namespace internal 2517 } // namespace internal
2527 } // namespace v8 2518 } // namespace v8
2528 2519
2529 #endif // V8_TARGET_ARCH_IA32 2520 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/crankshaft/ia32/lithium-ia32.h ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698