Source/wtf/OwnPtr.h - Issue 23960005: WTF::OwnPtr should behave similarly with the rest of WTF smart pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/OwnPtr.h

Issue 23960005: WTF::OwnPtr should behave similarly with the rest of WTF smart pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/wtf/OwnPtr.h

diff --git a/Source/wtf/OwnPtr.h b/Source/wtf/OwnPtr.h

index 3c524890e0bba0c7e3fdf2cc760856acacf2c688..c4feaeb0f421291e749d0eccba78285ab6032bd8 100644

--- a/Source/wtf/OwnPtr.h

+++ b/Source/wtf/OwnPtr.h

@@ -30,8 +30,6 @@

namespace WTF {

- // Unlike most of our smart pointers, OwnPtr can take either the pointer type or the pointed-to type.

template<typename T> class PassOwnPtr;

template<typename T> PassOwnPtr<T> adoptPtr(T*);

@@ -43,7 +41,7 @@ namespace WTF {

#endif

WTF_DISALLOW_CONSTRUCTION_FROM_ZERO(OwnPtr);

public:

- typedef typename RemovePointer<T>::Type ValueType;

abarth-chromium 2013/09/06 05:13:12 Is RemovePointer used anywhere else? Perhaps we c

+ typedef T ValueType;

typedef ValueType* PtrType;

OwnPtr() : m_ptr(0) { }

« no previous file with comments | « Source/web/PageOverlay.cpp ('k') | Source/wtf/PassOwnPtr.h » ('j') | no next file with comments »