Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 23960005: WTF::OwnPtr should behave similarly with the rest of WTF smart pointers (Closed)

Created:
7 years, 3 months ago by Mikhail
Modified:
7 years, 3 months ago
Reviewers:
tkent, abarth-chromium
CC:
blink-reviews, yurys+blink_chromium.org, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), jeez, eae+blinkwatch, dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, adamk+blink_chromium.org, darktears, loislo+blink_chromium.org, Steve Block, dino_apple.com, Eric Willigers, tkent, Nico, Chris Evans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

WTF::OwnPtr should behave similarly with the rest of WTF smart pointers Before the change OwnPtr could take either the pointer type or the pointed-to type, which was bad for the following reasons: - It distinguished OwnPtr behaviour from other WTF smart pointer classes behaviour (so it was confusing for the Client). - It was potential error-prone as it actually modified the type given by the Client in opaque way. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157328

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M Source/core/page/animation/CSSPropertyAnimation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/PageOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/OwnPtr.h View 2 chunks +1 line, -3 lines 1 comment Download
M Source/wtf/PassOwnPtr.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mikhail
Could you please have a look?
7 years, 3 months ago (2013-09-05 15:33:39 UTC) #1
tkent
lgtm
7 years, 3 months ago (2013-09-05 21:57:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/23960005/1
7 years, 3 months ago (2013-09-05 21:57:58 UTC) #3
commit-bot: I haz the power
Change committed as 157328
7 years, 3 months ago (2013-09-05 23:01:00 UTC) #4
abarth-chromium
https://codereview.chromium.org/23960005/diff/1/Source/wtf/OwnPtr.h File Source/wtf/OwnPtr.h (left): https://codereview.chromium.org/23960005/diff/1/Source/wtf/OwnPtr.h#oldcode46 Source/wtf/OwnPtr.h:46: typedef typename RemovePointer<T>::Type ValueType; Is RemovePointer used anywhere else? ...
7 years, 3 months ago (2013-09-06 05:13:12 UTC) #5
Mikhail
7 years, 3 months ago (2013-09-06 07:58:55 UTC) #6
Message was sent while issue was closed.
On 2013/09/06 05:13:12, abarth wrote:
> https://codereview.chromium.org/23960005/diff/1/Source/wtf/OwnPtr.h
> File Source/wtf/OwnPtr.h (left):
> 
> https://codereview.chromium.org/23960005/diff/1/Source/wtf/OwnPtr.h#oldcode46
> Source/wtf/OwnPtr.h:46: typedef typename RemovePointer<T>::Type ValueType;
> Is RemovePointer used anywhere else?  Perhaps we can remove it.

It's used also in CrossThreadCopier and RetainPtr.

Powered by Google App Engine
This is Rietveld 408576698