Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: runtime/vm/parser.cc

Issue 23960003: Disentangle AstNode::Name and AstNode::ShortName. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporated review comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 5a6219a3a0ec88fb529c14d0b15bcce234c292c6..e636ad0b98da72026e22547deda7d4ce49f4a17d 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -7552,7 +7552,7 @@ AstNode* Parser::CreateAssignmentNode(AstNode* original,
if (result == NULL) {
String& name = String::ZoneHandle();
if (original->IsTypeNode()) {
- name = Symbols::New(original->Name());
+ name = Symbols::New(original->AsTypeNode()->TypeName());
} else if ((left_ident != NULL) &&
(original->IsLiteralNode() ||
original->IsLoadLocalNode() ||
@@ -8226,8 +8226,10 @@ AstNode* Parser::ParseSelectors(AstNode* primary, bool is_cascade) {
selector = ParseInstanceCall(receiver, name);
}
} else if (primary->primary().IsTypeParameter()) {
+ // TODO(regis): Issue 13134. Make sure the error message is the
+ // one we want here and add a test covering this code.
const String& name = String::ZoneHandle(
- Symbols::New(primary->Name()));
+ TypeParameter::Cast(primary->primary()).name());
selector = ThrowNoSuchMethodError(primary->token_pos(),
current_class(),
name,
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698