Disentangle AstNode::Name and AstNode::ShortName.

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
 #include "vm/class_finalizer.h"
@@ skipping 7534 matching lines @@
 
 
 AstNode* Parser::CreateAssignmentNode(AstNode* original,
                                       AstNode* rhs,
                                       const String* left_ident,
                                       intptr_t left_pos) {
   AstNode* result = original->MakeAssignmentNode(rhs);
   if (result == NULL) {
     String& name = String::ZoneHandle();
     if (original->IsTypeNode()) {
-      name = Symbols::New(original->Name());
+      name = Symbols::New(original->AsTypeNode()->TypeName());
     } else if ((left_ident != NULL) &&
                (original->IsLiteralNode() ||
                 original->IsLoadLocalNode() ||
                 original->IsLoadStaticFieldNode())) {
       name = left_ident->raw();
     }
     if (name.IsNull()) {
       ErrorMsg(left_pos, "expression is not assignable");
     }
     result = ThrowNoSuchMethodError(original->token_pos(),
@@ skipping 653 matching lines @@
                                               name,
                                               NULL,  // No arguments.
                                               InvocationMirror::kStatic,
                                               InvocationMirror::kMethod);
           } else {
             // Treat as call to unresolved (instance) method.
             AstNode* receiver = LoadReceiver(primary->token_pos());
             selector = ParseInstanceCall(receiver, name);
           }
         } else if (primary->primary().IsTypeParameter()) {
-          const String& name = String::ZoneHandle(
-              Symbols::New(primary->Name()));
+          const String& name = String::ZoneHandle(Symbols::New("primary"));

[Kevin Millikin (Google), 2013/09/05 13:53:46]

I know this seems wrong (and not useful), but it matches the previous behavior
where PrimaryNode::Name() was not overridden.

This is dead code as far as our tests go, and it's sufficiently complicated that
I didn't dare change it.  Maybe someone on the team knows enough to take a look?

[regis, 2013/09/05 19:42:12]

This is not dead code. You can trigger this code with the test below. Maybe we
should add it as a test, or feel free to file a bug against me, or at least add
a TODO(regis).

class C<T> {
  foo() {
    T();
  }
}

main() {
  new C().foo();
}

As expected, 'primary' wrongly shows up in the error:

Unhandled exception:
No static method 'primary' declared in class 'C'.

NoSuchMethodError : method not found: 'primary'
Receiver: Type: class 'C'
Arguments: [...]
#0      NoSuchMethodError._throwNew (dart:core-patch/errors_patch.dart:99:5)
#1      C.foo (file:///usr/local/google/home/regis/bug2.dart:3:5)
#2      main (file:///usr/local/google/home/regis/bug2.dart:8:14)


So the name should be 'T', not 'primary'. Something like this should do:
Instead of "primary", use
TypeParameter::Cast(primary->primary()).name()

The next question is whether the error message makes sense. I need to check the
spec for the appropriate error to report here. It would make sense in a static
context, but in a dynamic context, I would rather expect "class 'C' has no
method 'T'".

[Kevin Millikin (Google), 2013/09/06 12:18:46]

Thanks for the clarification.  I filed issue 13134 and added TODO(regis) with
the issue number at this site in parser.cc.

           selector = ThrowNoSuchMethodError(primary->token_pos(),
                                             current_class(),
                                             name,
                                             NULL,  // No arguments.
                                             InvocationMirror::kStatic,
                                             InvocationMirror::kMethod);
         } else if (primary->primary().IsClass()) {
           const Class& type_class = Class::Cast(primary->primary());
           Type& type = Type::ZoneHandle(
               Type::New(type_class, TypeArguments::Handle(),
@@ skipping 2262 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart